[FEATURE ember-views-component-block-info] #10461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,8 @@ | |||
| "ember-application-instance-initializers": null, | |||
| "ember-application-initializer-context": null, | |||
| "ember-router-willtransition": true, | |||
| "ember-application-visit": null | |||
| "ember-application-visit": null, | |||
| "ember-views-component-has-block": null | |||
There was a problem hiding this comment.
Derp. Forgot to update the feature flag name. Will update shortly...
Adds a couple utility methods to detect block/block param presence:
* `hasBlock`
Adds the ability to easily detect if a component was invoked with or
without a block.
Example (`hasBlock` will be `false`):
```hbs
{{! templates/application.hbs }}
{{foo-bar}}
{{! templates/components/foo-bar.js }}
{{#if hasBlock}}
This will not be printed, because no block was provided
{{/if}}
```
Example (`hasBlock` will be `true`):
```hbs
{{! templates/application.hbs }}
{{#foo-bar}}
Hi!
{{/foo-bar}}
{{! templates/components/foo-bar.js }}
{{#if hasBlock}}
This will be printed because a block was provided
{{yield}}
{{/if}}
```
* `hasBlockParams`
Adds the ability to easily detect if a component was invoked with block parameter
supplied.
Example (`hasBlockParams` will be `false`):
```hbs
{{! templates/application.hbs }}
{{#foo-bar}}
Hi!.
{{/foo-bar}}
{{! templates/components/foo-bar.js }}
{{#if hasBlockParams}}
{{yield this}}
This will not be printed, because no block was provided
{{/if}}
```
Example (`hasBlockParams` will be `true`):
```hbs
{{! templates/application.hbs }}
{{#foo-bar as |foo|}}
Hi!
{{/foo-bar}}
{{! templates/components/foo-bar.js }}
{{#if hasBlockParams}}
{{yield this}}
This will be printed because a block was provided
{{/if}}
```
rwjblue
force-pushed
the
ember-views-component-has-block
branch
from
076655f to
a986881
Compare
rwjblue
changed the title
|
Updated documentation, and fixed incorrect feature flag name. |
mmun
added a commit
that referenced
this pull request
Feb 15, 2015
[FEATURE ember-views-component-block-info]
|
As I understand, the feature is broken in Ember v1.12.0
Please, check if I'm right ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple utility methods to detect block/block param presence:
hasBlockAdds the ability to easily detect if a component was invoked with or
without a block.
Example (
hasBlockwill befalse):Example (
hasBlockwill betrue):hasBlockParamsAdds the ability to easily detect if a component was invoked with block parameter
supplied.
Example (
hasBlockParamswill befalse):Example (
hasBlockParamswill betrue):Closes #10319.