-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag-less component with bound id attribute throwing an error #14369
Comments
just wanted to add that this seems to be fixed in beta and canary, maybe by #14363? |
Interesting, looking at the callstack and searching the sources the whole infrastructure changed. Does this have something to do with Glimmer 2? |
@HeroicEric as I mentioned yesterday, we should probably have a separate test for this scenario (id is used as a regular bound property, but not passed down to a child's elementId). Do you have time to tackle that? 😄 |
@chancancode I think I missed the conversation you're referring to but I can look into it 😄 |
@HeroicEric should this be closed as #14382 was merged? |
Yeah, closing this (as fixed in release branch). |
I ran into this issue while updating our application from Ember 2.4.2 to 2.8.0. Suddenly our subroutes wouldn't render anymore. Turns out that while you can assign an id to a tag-less component, the id's value must be a constant. Unfortunately in our applicaton the id is bound to a property.
There is a related issue (and PR) by @rwjblue that fixed this behavior for constant values: #14105
Here is a twiddle for easy reproduction. The error text reads:
The assertion can be found here.
The text was updated successfully, but these errors were encountered: