Skip to content

Commit

Permalink
[BUGFIX beta] move babel-plugin-ember-template-compilation to depende…
Browse files Browse the repository at this point in the history
…ncies

This is a bugfix to #20587.

We need to have an explicit dependency (not devDependency) on babel-plugin-ember-template-compilation because it's used from our addon main, which runs inside apps builds.

(cherry picked from commit 6d33841)
  • Loading branch information
ef4 authored and kategengler committed Dec 20, 2023
1 parent 551baae commit f42d68a
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ module.exports = {
plugins: [
babelHelperPlugin,
buildDebugMacroPlugin(!isProduction),
['babel-plugin-ember-template-compilation', { compilerPath }],
[require.resolve('babel-plugin-ember-template-compilation'), { compilerPath }],
...vmBabelPlugins({ isDebug: !isProduction }),
],
}),
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"@glimmer/vm-babel-plugins": "0.85.13",
"@simple-dom/interface": "^1.4.0",
"babel-plugin-debug-macros": "^0.3.4",
"babel-plugin-ember-template-compilation": "^2.1.1",
"babel-plugin-filter-imports": "^4.0.0",
"backburner.js": "^2.8.0",
"broccoli-concat": "^4.2.5",
Expand Down Expand Up @@ -120,7 +121,6 @@
"@typescript-eslint/parser": "^5.62.0",
"ast-types": "^0.14.2",
"auto-dist-tag": "^2.1.1",
"babel-plugin-ember-template-compilation": "^2.1.1",
"babel-template": "^6.26.0",
"broccoli-babel-transpiler": "^7.8.1",
"broccoli-persistent-filter": "^2.3.1",
Expand Down
13 changes: 10 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f42d68a

Please sign in to comment.