Skip to content

Commit

Permalink
Merge pull request #19462 from bertdeblock/rename-helper-arguments-in…
Browse files Browse the repository at this point in the history
…-blueprints

Use `positional` and `named` as the argument names in `ember g helper` blueprint
  • Loading branch information
rwjblue authored Mar 17, 2021
2 parents f84609a + 9edaec3 commit df149be
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions blueprints/helper/files/__root__/__collection__/__name__.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { helper } from '@ember/component/helper';

export default helper(function <%= camelizedModuleName %>(params/*, hash*/) {
return params;
export default helper(function <%= camelizedModuleName %>(positional/*, named*/) {
return positional;
});
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { helper as buildHelper } from '@ember/component/helper';

export function <%= camelizedModuleName %>(params/*, hash*/) {
return params;
export function <%= camelizedModuleName %>(positional/*, named*/) {
return positional;
}

export const helper = buildHelper(<%= camelizedModuleName %>);
4 changes: 2 additions & 2 deletions node-tests/fixtures/helper/helper.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { helper } from '@ember/component/helper';

export default helper(function fooBarBaz(params/*, hash*/) {
return params;
export default helper(function fooBarBaz(positional/*, named*/) {
return positional;
});
4 changes: 2 additions & 2 deletions node-tests/fixtures/helper/mu-helper.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { helper as buildHelper } from '@ember/component/helper';

export function fooBarBaz(params/*, hash*/) {
return params;
export function fooBarBaz(positional/*, named*/) {
return positional;
}

export const helper = buildHelper(fooBarBaz);

0 comments on commit df149be

Please sign in to comment.