Skip to content

Commit

Permalink
[BUGFIX beta] Fix double container destroy
Browse files Browse the repository at this point in the history
This code on the Engine Instance is not needed as it includes the
`ContainerProxyMixin`, which already takes care of destroying the 
container.

This duplicated destroy step was causing ember-cp-validations to
attempt to destroy validators twice. This destroy process tries to 
nullify some property with `o.set(‘model’, null)` on an object that is
already destroyed.
  • Loading branch information
cibernox committed May 4, 2017
1 parent 6408ce9 commit 7e4ace6
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions packages/ember-application/lib/system/engine-instance.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,6 @@ const EngineInstance = EmberObject.extend(RegistryProxyMixin, ContainerProxyMixi
this._super(...arguments);
},

/**
@private
*/
willDestroy() {
this._super(...arguments);
run(this.__container__, 'destroy');
},

/**
Build a new `Ember.EngineInstance` that's a child of this instance.
Expand Down

0 comments on commit 7e4ace6

Please sign in to comment.