-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add currentView property to Ember.ContainerView
- Loading branch information
Tom Dale
committed
May 3, 2012
1 parent
3e9dd6c
commit 00b8940
Showing
2 changed files
with
181 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit 00b8940
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomdale, perhaps, it could be useful to extend the feature to be able to pass an extended view. I have many view definitions like the one below:
Em.ContainerView.extend({
childViews: ['child'],
child: Em.View.extend({
....
})
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppcano Yep, we discussed doing that, as well as the ability to provide the currentView as a string.
👍 doc writing.