Remove dual-package emit #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
remove-ember-test-waiters
branch
from
0afc795
to
de786b4
Compare
28 tasks
NullVoxPopuli
force-pushed
the
remove-ember-test-waiters
branch
from
8ba8610
to
4d71513
Compare
Do you have this documented as a task somewhere? |
ye, towards the bottom here: #458 |
…as added to devDependencies so that the types for it exist -- and before then ember-auto-import didn't care
NullVoxPopuli
force-pushed
the
remove-ember-test-waiters
branch
from
8fc5a06
to
4668589
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context, Plan, etc: https://gist.github.com/NullVoxPopuli/eafc7dad6547de5e730098498b829e1f
Historically, this package has emitted two packages:
@ember/test-waitersnow only
@ember/test-waitersremains.This is a breaking change.
however we should still publish ember-test-waiters so we can ensure that folks can have only one copy of
@ember/test-waitersin their package graph.ember-test-waiterswould just be re-exports of@ember/test-waitersMonorepo required for this.