Ensure peer dependency validation is performed from the parent's root. #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, with our `require('the-peer-dep/package').version` check we
would incorrectly find the wrong version of peer dependencies when
linking `ember-qunit` (we end up finding the local `devDependencies`
version, and ignoring the version in the host application).
rwjblue
force-pushed
the
fix-peer-dependency-check-again
branch
from
56a549e to
3edf928
Compare
|
Thanks for fixing this. I did review, but wasn't able to approve on mobile. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, with our
require('the-peer-dep/package').versioncheck we would incorrectly find the wrong version of peer dependencies when linkingember-qunit(we end up finding the localdevDependenciesversion, and ignoring the version in the host application).