Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to native package #1064

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Convert to native package #1064

merged 3 commits into from
Jun 12, 2023

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented May 4, 2023 •
edited
Loading

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 4, 2023 01:49
This was referenced May 31, 2023
Merged
Merged
This was referenced Jun 1, 2023
Closed
Closed
This was referenced Jun 10, 2023
Merged
Merged
@NullVoxPopuli NullVoxPopuli force-pushed the convert-to-native-package branch from 44eee3f to 97465c6 Compare June 12, 2023 19:16
@NullVoxPopuli NullVoxPopuli force-pushed the convert-to-native-package branch from 97465c6 to 6402fff Compare June 12, 2023 19:26
NullVoxPopuli
NullVoxPopuli commented Jun 12, 2023
View reviewed changes
addon/testem.js
@@ -1,23 +0,0 @@
'use strict';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some additional cleanup here that was missed in the test-app extraction, or came back during one of my rebases

@MelSumner
Copy link
Contributor

MelSumner commented Jun 12, 2023 •
edited
Loading

There is still some polish needed. Just having CI pass isn't sufficient

  1. Can you expound on this?
  2. Or do you already have it captured in an issue?
  3. Also, would it block a release?

@NullVoxPopuli
Copy link
Collaborator Author

NullVoxPopuli commented Jun 12, 2023 •
edited
Loading

Can you expound on this? Or do you already have it captured in an issue?

apologies, I meant to remove that when I got C.I. green (few weeks back, I think?), and forgot. I removed it now.
I believe this PR is good to go

@MelSumner MelSumner merged commit 03e69a0 into emberjs:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ef4 ef4 ef4 approved these changes

@wagenet wagenet Awaiting requested review from wagenet

@MelSumner MelSumner Awaiting requested review from MelSumner

@kategengler kategengler Awaiting requested review from kategengler

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NullVoxPopuli @MelSumner @ef4