Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Release #340

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Prepare Release #340

merged 1 commit into from
Feb 21, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 14, 2024 •
edited
Loading

This PR is a preview of the release that release-plan has prepared. To release you should just merge this PR 👍

Release (2024-02-21)

@ember/optional-features 2.1.0 (minor)

🚀 Enhancement

  • @ember/optional-features
    • #334 Add feature for no-implicit-route-model - only effective from ember-source 5.7 (@achambers)

🏠 Internal

Committers: 3

@kategengler
Copy link
Member

kategengler commented Feb 15, 2024 •
edited
Loading

What's the implication of releasing this before Ember itself has the optional feature released? Seems like it could be confusing, since you could flip the flag and nothing would happen.

@mansona
Copy link
Member

mansona commented Feb 21, 2024

We discussed this in RFC Review (1) and decided that adding only effective from ember-source 5.7 was good enough to get this released now 👍

@mansona mansona merged commit 11d09ac into master Feb 21, 2024
@delete-merged-branch delete-merged-branch bot deleted the release-preview branch February 21, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kategengler @mansona