Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Adds isFeatureExplicitlySet API #148

Merged
merged 1 commit into from
Oct 23, 2019
Merged

[FEATURE] Adds isFeatureExplicitlySet API #148

merged 1 commit into from
Oct 23, 2019

Conversation

pzuraq
Copy link

@pzuraq pzuraq commented Oct 23, 2019

This API lets us check if a feature is explicitly set (e.g. given a
value in the config)

rwjblue
rwjblue approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can you also add a quick blurb in the README.md for this?

[FEATURE] Adds isFeatureExplicitlySet API
6201c70 
This API lets us check if a feature is explicitly set (e.g. given a
value in the config)
@pzuraq pzuraq force-pushed the feat/add-is-feature-set branch from b6de886 to 6201c70 Compare October 23, 2019 17:14
@pzuraq pzuraq merged commit 37d9998 into master Oct 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/add-is-feature-set branch October 23, 2019 17:39
@rwjblue rwjblue added the enhancement New feature or request label Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzuraq @rwjblue