Ensure babel.config.js is not used without useBabelConfig option
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been disabling loading of `.babelrc` files for quite some time, but missed the addition of `babel.config.js` to `@babel/core`'s configuration story. Now that we are attempting to roll out a version of ember-cli-babel that primarily leverages `babel.config.js` this mistake is coming back to haunt us. Without this explicit disabling of the `options.configFile` option ember-cli-babel versions **prior to** the ones that are adding support for `babel.config.js` (and wihtout opting in) are parsing `babel.config.js` files and ultimately breaking their builds. Note: this should not be a breaking change as we did not really support this before (and build errors would have always occurred), but without this change it is very difficult to adopt [email protected]'s new `useBabelConfig` option.
This was referenced Mar 18, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been disabling loading of
.babelrcfiles for quite some time, but missed the addition ofbabel.config.jsto@babel/core's configuration story.Now that we are attempting to roll out a version of ember-cli-babel that primarily leverages
babel.config.jsthis mistake is coming back to haunt us. Without this explicit disabling of theoptions.configFileoption ember-cli-babel versions prior to the ones that are adding support forbabel.config.js(and wihtout opting in) are parsingbabel.config.jsfiles and ultimately breaking their builds.Note: this should not be a breaking change as we did not really support this before (and build errors would have always occurred), but without this change it is very difficult to adopt [email protected]'s new
useBabelConfigoption.