Fix for undefined parent error #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsdwayne
referenced
this pull request
Feb 9, 2017
Prior to this, all visualization would show would be `Babel`, after this change we will have `Babel: <project-or-addon-name>`.
rwjblue
requested changes
Feb 9, 2017
index.js
Outdated
| @@ -120,7 +120,7 @@ module.exports = { | |||
| }, | |||
|
|
|||
| _getBabelOptions: function() { | |||
| var parentName = typeof this.parent.name === "function" ? this.parent.name() : this.parent.name; | |||
| var parentName = typeof this.parent !== 'undefined' ? (typeof this.parent.name === 'function' ? this.parent.name() : this.parent.name) : 'unknown'; | |||
There was a problem hiding this comment.
Maybe a slight tweak:
var parantName;
if (this.parent && typeof this.parent.name === 'function') {
parentName = this.parent.name();
} else if (this.parent) {
parentName = this.parent.name;
}I find it hard to reason about nested ternaries...
hsdwayne
commented
Feb 9, 2017
| parentName = this.parent.name; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@rwjblue Ok, how's this?
rwjblue
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error discussed in this comment 74c4723#commitcomment-20790735