Skip to content

Commit

Permalink
Only run acceptance tests against modern Node
Browse files Browse the repository at this point in the history
  • Loading branch information
rwjblue committed Dec 16, 2021
1 parent 7e9324f commit e520d1f
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 2 deletions.
35 changes: 33 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: lint
run: yarn lint:js

test:
node-tests:
name: "Node ${{ matrix.node }} - ${{ matrix.os }}"
runs-on: "${{matrix.os}}-latest"

Expand Down Expand Up @@ -56,7 +56,38 @@ jobs:
- name: install dependencies
run: yarn install --frozen-lockfile --ignore-engines
- name: test
run: yarn test
run: yarn test:node

acceptance-tests:
name: "Node ${{ matrix.node }} - ${{ matrix.os }}"
runs-on: "${{matrix.os}}-latest"

strategy:
matrix:
os: ['ubuntu', 'windows', 'macOS']
node: ['12', '14', '16']
exclude:
# excludes node 14 on macOS, this is because
# ember-cli (until ~ 3.12) calls
# `fs.writeFileSync('./tmp/.metadata_never_index)` on macOS platforms
# to instruct spotlight to avoid indexing the local tmp folder
# unfortunately, ember-cli does not pass a value for second arg (the
# content to write) and Node 14 added an assertion
#
# TODO: delete this when we have dropped Node 6 and can update
# ember-cli to a version that doesn't do this
- os: 'macOS'
node: '14'

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- name: install dependencies
run: yarn install --frozen-lockfile --ignore-engines
- name: test
run: yarn test:ember

floating-test:
name: Floating dependencies
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"start": "ember serve",
"test": "mocha node-tests && ember test",
"test:all": "mocha node-tests && ember try:each",
"test:ember": "ember test",
"test:node": "mocha node-tests",
"test:node:debug": "mocha debug node-tests"
},
Expand Down

0 comments on commit e520d1f

Please sign in to comment.