Ember cli deprecation workflow compatibility #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-classic-decorator patches `require`. ember-cli-deprecation-workflow invokes `require`. Avoid too early require invocation when there is no ember-data or ember-resolver packages by specifying `after` for ember-classic-decorator.
|
I can confirm that this fixes #90. Are there any blockers to get this released? |
|
@dwickern @andreyfel any idea what needs to happen to get this merged? |
|
@dwickern @andreyfel is something blocking the merge of this one? Or do we have an idea of when it could be released? |
|
I don't have a permission to merge it. @ef4 might be able to? |
|
Thanks, released in 3.0.1. |
thank you so much, you made my day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ember-classic-decorator is run before ember-cli-deprecation-workflow ember-cli-deprecation-workflow invokes
window.requirebefore the ember data classes exists. Therefore ember-classic-decorator's patch of window.require doesn't see ember data classes and it doesn't register them.Run ember-classic-decorator after ember-cli-deprecation-workflow to resolve this problem.
Fixes #80