Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables none/empty to isNone/isEmpty #981

Merged
merged 1 commit into from
May 16, 2013
Merged

Rename variables none/empty to isNone/isEmpty #981

merged 1 commit into from
May 16, 2013

Conversation

karlguillotte
Copy link
Contributor

Really small changes, this PR renames the variables:

  • none to isNone
  • empty to isEmpty

It makes the code easier to read.

Rename none ti isNone and empty to isEmpty variables. It makes the code
easier to read.
stefanpenner added a commit that referenced this pull request May 16, 2013
Rename variables none/empty to isNone/isEmpty
@stefanpenner stefanpenner merged commit 05e97a3 into emberjs:master May 16, 2013
@Floby
Copy link
Contributor

Floby commented Sep 30, 2013

Hello,
these changes make any business logic item using an isEmpty property break the ember-data layer.
isEmpty is a very common name for anything else than lazy loaded records. I suggest a name change or a warning when defining such a property on models.

@bradleypriest
Copy link
Member

This should have nothing to do with defining isEmpty on a model. It's literally just changing variable names within a closure.
Your issue must be due to something else.

@Floby
Copy link
Contributor

Floby commented Sep 30, 2013

You're right, I'll open its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants