Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ember/string v4 as dependency & allow ember-inflector v5 #9517

Closed
wants to merge 2 commits into from

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Jul 30, 2024

  • Some week ago there was released @ember/string v4. We should also allow v4 as peerDependency
  • Allow ember-inflector v5 as peerDependency

@mkszepp mkszepp changed the title Allow @ember/string v4 as dependency & allow minor releases for ember-inflector Allow @ember/string v4 as dependency & allow ember-inflector v5 Jul 30, 2024
@runspired runspired changed the base branch from release to main July 30, 2024 20:12
@runspired runspired changed the base branch from main to release July 30, 2024 20:12
@runspired
Copy link
Contributor

cam you PR this to main instead?

@mkszepp
Copy link
Contributor Author

mkszepp commented Aug 2, 2024

suppressed with #9519

as note: ember/string v4 was already added on main, there was not anymore necessary

@mkszepp mkszepp closed this Aug 2, 2024
@mkszepp mkszepp deleted the fix-peerDependencies branch August 2, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants