Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #9511 to lts-4-12: Add @ember/string v4 to peerDependencies #9510

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

SergeAstapov
Copy link
Contributor

Description

@ember/string v4 was recently published https://github.com/emberjs/ember-string/releases/tag/v4.0.0-%40ember%2Fstring

it's not possible to upgrade as @ember-data/store still requires v3.

Notes for the release

@SergeAstapov SergeAstapov changed the title Add @ember/string v4 to peerDependencies Backport #9319 to lts-4-12: Add @ember/string v4 to peerDependencies Jul 11, 2024
@SergeAstapov SergeAstapov changed the title Backport #9319 to lts-4-12: Add @ember/string v4 to peerDependencies Backport #9511 to lts-4-12: Add @ember/string v4 to peerDependencies Jul 11, 2024
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue backport-lts-prev PR targets the previous LTS labels Jul 11, 2024
@PavinStrickland
Copy link

The error message indicates that the self-installer failed with code 1, which could be the cause of the setup job failure. To resolve this, you may need to investigate the pnpm/action-setup step and check for any issues or misconfigurations in the self-installer script.

@PavinStrickland
Copy link

Also, the checks for lint, special-build-tests, and Test Chrome have failed shortly after beginning, which might suggest a common issue affecting them. Given these checks failed quickly, it might be due to misconfiguration, missing dependencies, or other immediate errors in the setup. Investigating the details of these failed checks could offer insights into the cause of the failures and guide necessary fixes. The 'lts' and 'releases' checks being skipped should be reviewed to understand why they were not executed. The fact that there are no conflicts with the base branch means that once the issues causing the failures are resolved, the pull request should be mergeable.

@PavinStrickland
Copy link

jobs:
lint:
runs-on: ubuntu-latest

     steps:
       - name: Check out repository
         uses: actions/checkout@v3

       - name: Set up Node.js
         uses: actions/setup-node@v2
         with:
           node-version: '16.x'
     
       - name: Run custom setup
         run: ./.github/actions/setup
         continue-on-error: false # ensure the job stops if this step fails

       - name: Lint JavaScript
         if: success()
         run: npm run lint:js

@wagenet wagenet mentioned this pull request Aug 21, 2024
@wagenet wagenet force-pushed the bump-ember-string-lts branch from 2cbc664 to 04c6761 Compare August 21, 2024 19:40
@wagenet wagenet force-pushed the bump-ember-string-lts branch from 04c6761 to 8253d4e Compare August 21, 2024 19:45
@wagenet wagenet merged commit 38c782d into emberjs:lts-4-12 Aug 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-lts-prev PR targets the previous LTS 🏷️ bug This PR primarily fixes a reported issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants