Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Switch all uses of @ember/error to native Error #8412

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Feb 21, 2023

Description

Ember 3.8 began simply re-exporting Error at this specifier, and Ember 5.0 drops the old package entirely. Switch to just using native Error accordingly, and drop all bits referring to the old class.

Notes for the release

N/A (I think?) – this shouldn't change literally anything from consumers' POV.


This unblocks emberjs/ember.js#20379 (part of the Ember 5.0 cleanup).

Ember 3.8 began simply re-exporting `Error` at this specifier, and
Ember 5.0 drops the old package entirely. Switch to just using native
`Error` accordingly, and drop all bits referring to the old class.
@chriskrycho chriskrycho changed the title Switch all uses of @ember/error to native Error cleanup: Switch all uses of @ember/error to native Error Feb 22, 2023
@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality labels Feb 24, 2023
@runspired runspired merged commit dfd8668 into master Feb 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the no-ember-error branch February 24, 2023 20:05
@runspired runspired added this to the 🔌 Unplug milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 release PR should be backported to release 🏷️ cleanup This PR primarily removes deprecated functionality 🔌 Project Unplug 🔌
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants