Remove IE11 hacks #7741

snewcomer · 2021-11-05T03:56:12Z

prep for 4.0!

runspired

These changes are good but the build tooling will have to be updated to not include IE11 as well, that's the reason for most the infra test failures.

Primarily this means updating our actions configs.

Since the IE11 size is no longer relevant we can drop that bit from the asset size report entirely.

github-actions · 2021-11-05T12:29:16Z

Asset Size Report for 24cbdd8

Modern Builds

EmberData increased by +1.26 KB uncompressed but decreased by -164.0 B compressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +516.0 B.
⚠️ The uncompressed size of the package @ember-data/model has increased by +181.0 B.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +370.0 B.
⚠️ The uncompressed size of the package @ember-data/serializer has increased by +106.0 B.
⚠️ The uncompressed size of the package @ember-data/adapter has increased by +98.0 B.
⚠️ The uncompressed size of the package ember-data has increased by +8.0 B.
⚠️ The uncompressed size of the package @ember-data/debug has increased by +8.0 B.

Changeset


EmberData +179.86 KB +1.26 KB (+38.6 KB -164.0 B compressed)
    @ember-data/store +72.43 KB +516.0 B (+15.54 KB -65.75 B compressed)
        @ember-data/store/-private +71.51 KB +516.0 B (+15.35 KB -65.75 B compressed)
    @ember-data/model +28.73 KB +181.0 B (+6.17 KB -23.06 B compressed)
        @ember-data/model/-private +28.26 KB +181.0 B (+6.06 KB -23.06 B compressed)
    @ember-data/record-data +24.1 KB +370.0 B (+5.17 KB -47.15 B compressed)
        @ember-data/record-data/-private +24.1 KB +370.0 B (+5.17 KB -47.15 B compressed)
    @ember-data/serializer +19.73 KB +106.0 B (+4.23 KB -13.51 B compressed)
        @ember-data/serializer/json +7.2 KB +12.0 B (+1.55 KB -1.53 B compressed)
        @ember-data/serializer/-private +5.52 KB +34.0 B (+1.18 KB -4.33 B compressed)
        @ember-data/serializer/json-api +3.75 KB +24.0 B (+824.03 B -3.06 B compressed)
        @ember-data/serializer/rest +2.8 KB +36.0 B (+614.37 B -4.59 B compressed)
    @ember-data/adapter +15.98 KB +98.0 B (+3.43 KB -12.49 B compressed)
        @ember-data/adapter/rest +8.08 KB +42.0 B (+1.73 KB -5.35 B compressed)
        @ember-data/adapter/-private +3.79 KB +34.0 B (+833.47 B -4.33 B compressed)
        @ember-data/adapter/error +1.96 KB +16.0 B (+430.25 B -2.04 B compressed)
        @ember-data/adapter/json-api +1.05 KB +6.0 B (+230.47 B -0.76 B compressed)
    ember-data +9.37 KB +8.0 B (+2.01 KB -1.02 B compressed)
        ember-data/index +2.42 KB +2.0 B (+531.33 B -0.25 B compressed)
        ember-data/-private +2.13 KB +6.0 B (+467.38 B -0.76 B compressed)
    @ember-data/debug +2.82 KB +8.0 B (+618.88 B -1.02 B compressed)
        @ember-data/debug/index +2.32 KB +2.0 B (+510.51 B -0.25 B compressed)
        @ember-data/debug/setup +505.0 B +6.0 B (+108.36 B -0.76 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.86 KB' │
│ compressed │ '38.60 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.43 KB' │
│  compressed  │ '15.54 KB' │
│ % Of Library │   '40.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.51 KB  | 15.35 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 200.85 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.73 KB' │
│  compressed  │ '6.17 KB'  │
│ % Of Library │   '16.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.26 KB  | 6.06 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 104.29 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.10 KB' │
│  compressed  │ '5.17 KB'  │
│ % Of Library │   '13.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.10 KB  | 5.17 KB    | 100.0         | 13.4

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.73 KB' │
│  compressed  │ '4.23 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.20 KB   | 1.55 KB    | 36.5          | 4.0
	@ember-data/serializer/-private                   | 5.52 KB   | 1.18 KB    | 28.0          | 3.1
	@ember-data/serializer/json-api                   | 3.75 KB   | 824.03 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.80 KB   | 614.37 B   | 14.2          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 55.36 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.13 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.98 KB' │
│  compressed  │ '3.43 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.08 KB   | 1.73 KB    | 50.6          | 4.5
	@ember-data/adapter/-private                      | 3.79 KB   | 833.47 B   | 23.7          | 2.1
	@ember-data/adapter/error                         | 1.96 KB   | 430.25 B   | 12.3          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 241.41 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.05 KB   | 230.47 B   | 6.6           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.37 KB' │
│  compressed  │ '2.01 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 531.33 B   | 25.8          | 1.3
	ember-data/-private                               | 2.13 KB   | 467.38 B   | 22.7          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 261.15 B   | 12.7          | 0.7
	ember-data/setup-container                        | 387.00 B  | 83.04 B    | 4.0           | 0.2
	ember-data/relationships                          | 318.00 B  | 68.24 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.79 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.86 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.57 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.14 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.14 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.71 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.85 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.78 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.49 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.63 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.63 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.78 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 34.76 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.44 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 636.04 B   | 43.1          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 349.13 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 101.50 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 101.07 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 80.04 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 75.53 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 68.24 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.51 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '618.88 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 510.51 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 108.36 B   | 17.5          | 0.3

Modern Builds (No Rollup)

EmberData increased by +1.16 KB uncompressed but decreased by -71.0 B compressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +443.0 B.
⚠️ The uncompressed size of the package @ember-data/model has increased by +178.0 B.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +358.0 B.
⚠️ The uncompressed size of the package @ember-data/serializer has increased by +106.0 B.
⚠️ The uncompressed size of the package @ember-data/adapter has increased by +94.0 B.
⚠️ The uncompressed size of the package ember-data has increased by +4.0 B.
⚠️ The uncompressed size of the package @ember-data/debug has increased by +8.0 B.

Changeset


EmberData +220.47 KB +1.16 KB (+42.03 KB -71.0 B compressed)
    @ember-data/store +97.18 KB +443.0 B (+18.53 KB -26.41 B compressed)
        @ember-data/store/-private/system/core-store +17.45 KB +180.0 B (+3.33 KB -10.73 B compressed)
        @ember-data/store/-private/system/model/internal-model +14.52 KB +100.0 B (+2.77 KB -5.96 B compressed)
        @ember-data/store/-private/system/model/states +5.45 KB +13.0 B (+1.04 KB -0.77 B compressed)
        @ember-data/store/-private/system/fetch-manager +5.08 KB +40.0 B (+992.47 B -2.38 B compressed)
        @ember-data/store/-private/system/store/finders +4.5 KB -48.0 B (+879.23 B +2.86 B compressed)
        @ember-data/store/-private/system/record-array-manager +4.18 KB +43.0 B (+816.89 B -2.56 B compressed)
        @ember-data/store/-private/identifiers/cache +3.92 KB +14.0 B (+765.22 B -0.83 B compressed)
        @ember-data/store/-private/system/store/record-data-store-wrapper +3.46 KB +53.0 B (+675.05 B -3.16 B compressed)
        @ember-data/store/-private/system/snapshot +3.1 KB +26.0 B (+604.7 B -1.55 B compressed)
        @ember-data/store/-private/system/store/internal-model-factory +2.87 KB +37.0 B (+560.09 B -2.21 B compressed)
        @ember-data/store/-private/system/request-cache +1.79 KB +19.0 B (+348.87 B -1.13 B compressed)
        @ember-data/store/-private/system/references/has-many +1.54 KB +5.0 B (+300.06 B -0.3 B compressed)
        @ember-data/store/-private/system/schema-definition-service +1.52 KB +6.0 B (+296.06 B -0.36 B compressed)
        @ember-data/store/-private/system/references/belongs-to +1.32 KB +2.0 B (+258.5 B -0.12 B compressed)
        @ember-data/store/-private/system/model/shim-model-class +1.32 KB +2.0 B (+257.55 B -0.12 B compressed)
        @ember-data/store/-private/identifiers/utils/uuid-v4 +999.0 B -79.0 B (+190.44 B +4.71 B compressed)
        @ember-data/store/-private/system/references/reference +916.0 B +2.0 B (+174.62 B -0.12 B compressed)
        @ember-data/store/-private/system/errors-utils +802.0 B +6.0 B (+152.89 B -0.36 B compressed)
        @ember-data/store/-private/system/record-notification-manager +699.0 B +2.0 B (+133.25 B -0.12 B compressed)
        @ember-data/store/-private/utils/construct-resource +699.0 B +4.0 B (+133.25 B -0.24 B compressed)
        @ember-data/store/-private/system/promise-proxies +609.0 B +2.0 B (+116.09 B -0.12 B compressed)
        @ember-data/store/-private/system/identity-map +454.0 B +4.0 B (+86.55 B -0.24 B compressed)
        @ember-data/store/-private/system/record-data-for +392.0 B +2.0 B (+74.73 B -0.12 B compressed)
        @ember-data/store/-private/ts-interfaces/identifier +348.0 B +4.0 B (+66.34 B -0.24 B compressed)
        @ember-data/store/-private/identifiers/is-stable-identifier +329.0 B +2.0 B (+62.72 B -0.12 B compressed)
        @ember-data/store/-private/system/backburner +271.0 B +2.0 B (+51.66 B -0.12 B compressed)
    @ember-data/model +32.83 KB +178.0 B (+6.26 KB -10.61 B compressed)
        @ember-data/model/-private/model +9.93 KB +45.0 B (+1.89 KB -2.68 B compressed)
        @ember-data/model/-private/record-state +6.23 KB +23.0 B (+1.19 KB -1.37 B compressed)
        @ember-data/model/-private/system/many-array +2.86 KB +8.0 B (+557.81 B -0.48 B compressed)
        @ember-data/model/-private/errors +2.1 KB +16.0 B (+409.87 B -0.95 B compressed)
        @ember-data/model/-private/system/relationships/relationship-meta +1.31 KB +54.0 B (+254.88 B -3.22 B compressed)
        @ember-data/model/-private/attr +874.0 B +17.0 B (+166.61 B -1.01 B compressed)
        @ember-data/model/-private/belongs-to +688.0 B +1.0 B (+131.16 B -0.06 B compressed)
        @ember-data/model/-private/system/diff-array +452.0 B +14.0 B (+86.16 B -0.83 B compressed)
    @ember-data/record-data +31.15 KB +358.0 B (+5.94 KB -21.34 B compressed)
        @ember-data/record-data/-private/record-data +8.28 KB +98.0 B (+1.58 KB -5.84 B compressed)
        @ember-data/record-data/-private/graph/index +4.92 KB +57.0 B (+959.48 B -3.4 B compressed)
        @ember-data/record-data/-private/graph/operations/replace-related-records +3.21 KB +77.0 B (+627.58 B -4.59 B compressed)
        @ember-data/record-data/-private/graph/-edge-definition +2.86 KB +42.0 B (+557.43 B -2.5 B compressed)
        @ember-data/record-data/-private/relationships/state/has-many +2.04 KB +27.0 B (+397.48 B -1.61 B compressed)
        @ember-data/record-data/-private/relationships/state/belongs-to +1.94 KB +15.0 B (+378.22 B -0.89 B compressed)
        @ember-data/record-data/-private/graph/operations/update-relationship +1.51 KB +8.0 B (+294.91 B -0.48 B compressed)
        @ember-data/record-data/-private/graph/-utils +1.06 KB +6.0 B (+206.08 B -0.36 B compressed)
        @ember-data/record-data/-private/graph/operations/replace-related-record +1.04 KB +8.0 B (+203.79 B -0.48 B compressed)
        @ember-data/record-data/-private/graph/operations/add-to-related-records +798.0 B +10.0 B (+152.13 B -0.6 B compressed)
        @ember-data/record-data/-private/graph/operations/remove-from-related-records +677.0 B +10.0 B (+129.06 B -0.6 B compressed)
    @ember-data/serializer +22.15 KB +106.0 B (+4.22 KB -6.32 B compressed)
        @ember-data/serializer/json +7.2 KB +12.0 B (+1.37 KB -0.72 B compressed)
        @ember-data/serializer/-private/embedded-records-mixin +4.41 KB +26.0 B (+861.11 B -1.55 B compressed)
        @ember-data/serializer/json-api +3.75 KB +24.0 B (+732.05 B -1.43 B compressed)
        @ember-data/serializer/rest +2.8 KB +36.0 B (+545.8 B -2.15 B compressed)
        @ember-data/serializer/-private/transforms/number +453.0 B +8.0 B (+86.35 B -0.48 B compressed)
    @ember-data/adapter +18.1 KB +94.0 B (+3.45 KB -5.6 B compressed)
        @ember-data/adapter/rest +8.08 KB +42.0 B (+1.54 KB -2.5 B compressed)
        @ember-data/adapter/error +1.96 KB +16.0 B (+382.23 B -0.95 B compressed)
        @ember-data/adapter/-private/build-url-mixin +1.93 KB +8.0 B (+377.46 B -0.48 B compressed)
        @ember-data/adapter/json-api +1.05 KB +6.0 B (+204.74 B -0.36 B compressed)
        @ember-data/adapter/-private/utils/serialize-query-params +790.0 B +2.0 B (+150.6 B -0.12 B compressed)
        @ember-data/adapter/-private/utils/determine-body-promise +568.0 B +2.0 B (+108.28 B -0.12 B compressed)
        @ember-data/adapter/-private/utils/parse-response-headers +494.0 B +14.0 B (+94.17 B -0.83 B compressed)
        @ember-data/adapter/-private/utils/serialize-into-hash +351.0 B +4.0 B (+66.91 B -0.24 B compressed)
    ember-data +9.53 KB +4.0 B (+1.82 KB -0.24 B compressed)
        ember-data/index +2.42 KB +2.0 B (+472.02 B -0.12 B compressed)
        ember-data/-private/core +368.0 B +2.0 B (+70.15 B -0.12 B compressed)
    @ember-data/debug +2.82 KB +8.0 B (+549.8 B -0.48 B compressed)
        @ember-data/debug/index +2.32 KB +2.0 B (+453.52 B -0.12 B compressed)
        @ember-data/debug/setup +505.0 B +6.0 B (+96.27 B -0.36 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.47 KB' │
│ compressed │ '42.03 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.18 KB' │
│  compressed  │ '18.53 KB' │
│ % Of Library │   '44.1'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.45 KB  | 3.33 KB    | 18.0          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.52 KB  | 2.77 KB    | 14.9          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.45 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.08 KB   | 992.47 B   | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.50 KB   | 879.23 B   | 4.6           | 2.0
	@ember-data/store/-private/system/record-array-manager                             | 4.18 KB   | 816.89 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.92 KB   | 765.22 B   | 4.0           | 1.8
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.46 KB   | 675.05 B   | 3.6           | 1.6
	@ember-data/store/-private/index                                                   | 3.36 KB   | 655.99 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 604.70 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.87 KB   | 560.09 B   | 3.0           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 445.14 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.94 KB   | 379.37 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 348.87 B   | 1.8           | 0.8
	@ember-data/store/-private/system/references/has-many                              | 1.54 KB   | 300.06 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 296.06 B   | 1.6           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 258.50 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 257.55 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 222.66 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 190.44 B   | 1.0           | 0.4
	@ember-data/store/-private/system/references/record                                | 984.00 B  | 187.58 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 178.43 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 923.00 B  | 175.96 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 916.00 B  | 174.62 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 168.90 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 152.89 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 143.55 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 699.00 B  | 133.25 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 133.25 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 116.09 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.00 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 100.46 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 94.17 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.84 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 86.55 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 392.00 B  | 74.73 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 66.34 B    | 0.3           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 329.00 B  | 62.72 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.24 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.28 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.66 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 48.99 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.94 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.41 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.03 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.21 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.83 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.64 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.64 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.64 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.69 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.50 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.50 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.73 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.73 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.97 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.40 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.83 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.83 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.83 KB' │
│  compressed  │ '6.26 KB'  │
│ % Of Library │   '14.9'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.93 KB   | 1.89 KB    | 30.3          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.19 KB    | 19.0          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 742.54 B   | 11.6          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.86 KB   | 557.81 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.10 KB   | 409.87 B   | 6.4           | 1.0
	@ember-data/model/-private/index                                      | 1.42 KB   | 277.57 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 254.88 B   | 4.0           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 166.61 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 161.09 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 131.16 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 123.53 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 92.65 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 86.16 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.21 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.26 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 81.40 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.15 KB' │
│  compressed  │ '5.94 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.28 KB   | 1.58 KB    | 26.6          | 3.8
	@ember-data/record-data/-private/graph/index                                      | 4.92 KB   | 959.48 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.21 KB   | 627.58 B   | 10.3          | 1.5
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.86 KB   | 557.43 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 397.48 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 378.22 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 294.91 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 206.08 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.79 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 186.25 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 152.13 B   | 2.5           | 0.4
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 131.92 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 129.06 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.39 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.85 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.37 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.59 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.59 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.15 KB' │
│  compressed  │ '4.22 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.20 KB   | 1.37 KB    | 32.5          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.41 KB   | 861.11 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 732.05 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.80 KB   | 545.80 B   | 12.6          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 230.67 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.03 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 97.41 B    | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 86.35 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 72.63 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.76 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.18 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.08 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.98 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.10 KB' │
│  compressed  │ '3.45 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.08 KB   | 1.54 KB    | 44.6          | 3.7
	@ember-data/adapter/error                                     | 1.96 KB   | 382.23 B   | 10.8          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 377.46 B   | 10.7          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 214.46 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 1.05 KB   | 204.74 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.31 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 790.00 B  | 150.60 B   | 4.3           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 568.00 B  | 108.28 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 94.17 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.55 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 351.00 B  | 66.91 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.32 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.02 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.53 KB' │
│  compressed  │ '1.82 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 472.02 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 376.32 B   | 20.2          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 232.00 B   | 12.5          | 0.5
	ember-data/setup-container                        | 387.00 B  | 73.77 B    | 4.0           | 0.2
	ember-data/-private/core                          | 368.00 B  | 70.15 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.62 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.23 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.85 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.70 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.32 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.32 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.94 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.18 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.22 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.08 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.32 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.32 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.55 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 30.88 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 565.05 B   | 43.1          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.16 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.17 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 89.79 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.10 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.10 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.62 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.42 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '549.80 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 453.52 B   | 82.5          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.27 B    | 17.5          | 0.2

snewcomer · 2021-11-05T12:35:30Z

packages/private-build-infra/src/stripped-build-plugins.js

@@ -22,7 +21,7 @@ module.exports = function (environment, app, compatVersion) {
    plugins.push([FilterImports, { imports: filteredImports }]);
  }

-  plugins.push([TransformBlockScoping, { throwIfClosureRequired: true }], ...DebugMacros);
+  plugins.push(...DebugMacros);


@runspired This is the right removal, right?

No, though it's likely also safe to remove this now. There's several GitHub actions/test run scenario infra bits that expect an IE11 compat build.

github-actions · 2021-11-05T12:57:26Z

Performance Report for 24cbdd8

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-19ms to 31ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-12ms to 14ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-12ms to 24ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-4ms to 9ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-10ms to 2ms]

Scenario - unload: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +35ms [7ms to 57ms] OR +1.12% [0.23% to 1.84%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-6ms to 10ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [0ms to 34ms]
⚠️ Phase [start-unload-records] => [end-unload-records]
phase estimated regression +17ms [11ms to 24ms] OR +2.67% [1.66% to 3.74%]
⚠️ Phase [end-unload-records] => [Test End]
phase estimated regression +1ms [0ms to 1ms] OR +1.02% [0.31% to 1.76%]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-7ms to 35ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 4ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-14ms to 13ms]
⚠️ Phase [start-destroy-records] => [end-destroy-records]
phase estimated regression +17ms [10ms to 25ms] OR +1.64% [0.96% to 2.39%]
✅ Phase [end-destroy-records] => [Test End]
phase estimated improvement -1ms [-1ms to 0ms] OR -0.89% [-1.59% to -0.11%]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-26ms to 4ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-10ms to 11ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-11ms to 3ms]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -6ms [-9ms to -2ms] OR -2.51% [-4.02% to -1.1%]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-31ms to 4ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 8ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -15ms [-29ms to -1ms] OR -0.94% [-1.86% to -0.05%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-1ms to 4ms]

* Remove IE11 hacks * rm plugin-transform-block-scoping

snewcomer added 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality labels Nov 5, 2021

snewcomer self-assigned this Nov 5, 2021

runspired approved these changes Nov 5, 2021

View reviewed changes

runspired self-requested a review November 5, 2021 06:54

runspired approved these changes Nov 5, 2021

View reviewed changes

Remove IE11 hacks

f02e0f4

snewcomer force-pushed the sn/cleanup-ie11 branch from d927121 to f02e0f4 Compare November 5, 2021 11:47

rm plugin-transform-block-scoping

24cbdd8

snewcomer commented Nov 5, 2021

View reviewed changes

snewcomer merged commit eb78447 into master Nov 5, 2021

delete-merged-branch bot deleted the sn/cleanup-ie11 branch November 5, 2021 17:37

snewcomer added a commit that referenced this pull request Nov 21, 2021

Remove IE11 hacks (#7741)

5bc3eae

* Remove IE11 hacks * rm plugin-transform-block-scoping

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove IE11 hacks #7741

Remove IE11 hacks #7741

snewcomer commented Nov 5, 2021

runspired left a comment

github-actions bot commented Nov 5, 2021

Warnings

Warnings

snewcomer Nov 5, 2021

runspired Nov 5, 2021

github-actions bot commented Nov 5, 2021

Remove IE11 hacks #7741

Remove IE11 hacks #7741

Conversation

snewcomer commented Nov 5, 2021

runspired left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 5, 2021

Warnings

Warnings

snewcomer Nov 5, 2021

Choose a reason for hiding this comment

runspired Nov 5, 2021

Choose a reason for hiding this comment

github-actions bot commented Nov 5, 2021