Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert relationships to use identifiers #7470

Merged
merged 3 commits into from
Apr 23, 2021
Merged

chore: convert relationships to use identifiers #7470

merged 3 commits into from
Apr 23, 2021

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Apr 16, 2021 •
edited
Loading

Revisits and replaces #6845

@github-actions
Copy link

github-actions bot commented Apr 17, 2021 •
edited
Loading

Asset Size Report for 31dbbb7

IE11 Builds

🛑 The size of the library EmberData has increased by +1.4 KB (+428.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +323.0 B.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +1.08 KB.

Changeset


EmberData +178.56 KB +1.4 KB (+36.68 KB +428.0 B compressed)
    @ember-data/store +76.92 KB +323.0 B (+15.8 KB +96.4 B compressed)
        @ember-data/store/-private +76.01 KB +323.0 B (+15.61 KB +96.4 B compressed)
    @ember-data/record-data +26.17 KB +1.08 KB (+5.38 KB +331.6 B compressed)
        @ember-data/record-data/-private +26.17 KB +1.08 KB (+5.38 KB +331.6 B compressed)
Full Asset Analysis (IE11) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '178.56 KB' │
│ compressed │ '36.68 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '76.92 KB' │
│  compressed  │ '15.80 KB' │
│ % Of Library │   '43.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 76.01 KB  | 15.61 KB   | 98.8          | 42.6
	@ember-data/store/index                           | 936.00 B  | 192.28 B   | 1.2           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '26.17 KB' │
│  compressed  │ '5.38 KB'  │
│ % Of Library │   '14.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 26.17 KB  | 5.38 KB    | 100.0         | 14.7

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.84 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.75 KB   | 1.59 KB    | 37.2          | 4.3
	@ember-data/serializer/-private                   | 5.69 KB   | 1.17 KB    | 27.3          | 3.2
	@ember-data/serializer/json-api                   | 3.95 KB   | 830.57 B   | 18.9          | 2.2
	@ember-data/serializer/rest                       | 3.00 KB   | 630.27 B   | 14.4          | 1.7
	@ember-data/serializer/index                      | 258.00 B  | 53.00 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 44.16 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.47 KB' │
│  compressed  │ '3.80 KB'  │
│ % Of Library │   '10.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 9.31 KB   | 1.91 KB    | 50.4          | 5.2
	@ember-data/adapter/-private                      | 3.80 KB   | 800.37 B   | 20.6          | 2.1
	@ember-data/adapter/error                         | 1.95 KB   | 409.63 B   | 10.5          | 1.1
	@ember-data/adapter/index                         | 1.81 KB   | 380.05 B   | 9.8           | 1.0
	@ember-data/adapter/json-api                      | 1.60 KB   | 337.32 B   | 8.7           | 0.9

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.80 KB' │
│  compressed  │ '3.25 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 15.32 KB  | 3.15 KB    | 97.0          | 8.6
	@ember-data/model/index                           | 486.00 B  | 99.84 B    | 3.0           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '1.90 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 488.73 B   | 25.1          | 1.3
	ember-data/-private                               | 1.98 KB   | 416.82 B   | 21.4          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 250.01 B   | 12.9          | 0.7
	ember-data/setup-container                        | 503.00 B  | 103.33 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 65.32 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 56.28 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.56 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.33 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.92 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.92 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 49.50 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.68 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.66 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.42 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 45.60 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.60 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.78 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 33.28 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.15 KB' │
│  compressed  │ '1.67 KB' │
│ % Of Library │   '4.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 654.10 B   | 38.1          | 1.7
	ember-inflector/lib/helpers/pluralize             | 1.62 KB   | 340.61 B   | 19.9          | 0.9
	ember-inflector/lib/system/inflections            | 1.59 KB   | 334.24 B   | 19.5          | 0.9
	ember-inflector/index                             | 473.00 B  | 97.17 B    | 5.7           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 96.76 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 332.00 B  | 68.20 B    | 4.0           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 63.27 B    | 3.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.80 B    | 3.5           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.96 KB'  │
│  compressed  │ '622.67 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.47 KB   | 519.95 B   | 83.5          | 1.4
	@ember-data/debug/setup                           | 500.00 B  | 102.71 B   | 16.5          | 0.3

Modern Builds

🛑 The size of the library EmberData has increased by +1.35 KB (+483.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +307.0 B.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +1.05 KB.

Changeset


EmberData +159.23 KB +1.35 KB (+34.64 KB +483.0 B compressed)
    @ember-data/store +67.8 KB +307.0 B (+14.75 KB +106.98 B compressed)
        @ember-data/store/-private +66.89 KB +307.0 B (+14.55 KB +106.98 B compressed)
    @ember-data/record-data +23.05 KB +1.05 KB (+5.01 KB +376.02 B compressed)
        @ember-data/record-data/-private +23.05 KB +1.05 KB (+5.01 KB +376.02 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '159.23 KB' │
│ compressed │ '34.64 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '67.80 KB' │
│  compressed  │ '14.75 KB' │
│ % Of Library │   '42.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 66.89 KB  | 14.55 KB   | 98.7          | 42.0
	@ember-data/store/index                           | 936.00 B  | 203.59 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.05 KB' │
│  compressed  │ '5.01 KB'  │
│ % Of Library │   '14.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.05 KB  | 5.01 KB    | 100.0         | 14.5

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.37 KB' │
│  compressed  │ '4.21 KB'  │
│ % Of Library │   '12.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.12 KB   | 1.55 KB    | 36.8          | 4.5
	@ember-data/serializer/-private                   | 5.37 KB   | 1.17 KB    | 27.7          | 3.4
	@ember-data/serializer/json-api                   | 3.72 KB   | 827.85 B   | 19.2          | 2.3
	@ember-data/serializer/rest                       | 2.71 KB   | 604.25 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 52.85 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.76 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '16.02 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '10.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.37 KB   | 1.82 KB    | 52.2          | 5.3
	@ember-data/adapter/-private                      | 3.58 KB   | 798.27 B   | 22.4          | 2.3
	@ember-data/adapter/error                         | 1.91 KB   | 426.10 B   | 11.9          | 1.2
	@ember-data/adapter/index                         | 1.14 KB   | 253.18 B   | 7.1           | 0.7
	@ember-data/adapter/json-api                      | 1.02 KB   | 226.86 B   | 6.4           | 0.6

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.40 KB' │
│  compressed  │ '3.13 KB'  │
│ % Of Library │   '9.0'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 13.92 KB  | 3.03 KB    | 96.7          | 8.7
	@ember-data/model/index                           | 486.00 B  | 105.71 B   | 3.3           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '2.01 KB' │
│ % Of Library │   '5.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 517.46 B   | 25.1          | 1.5
	ember-data/-private                               | 1.98 KB   | 441.33 B   | 21.4          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 264.71 B   | 12.9          | 0.7
	ember-data/setup-container                        | 503.00 B  | 109.40 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 69.16 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.59 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 54.59 B    | 2.7           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 53.29 B    | 2.6           | 0.2
	ember-data/serializers/json                       | 243.00 B  | 52.85 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.85 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 52.42 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.55 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.46 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.15 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.28 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.28 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.41 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 35.23 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.45 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 641.44 B   | 43.3          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 353.89 B   | 23.9          | 1.0
	ember-inflector/index                             | 473.00 B  | 102.88 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.44 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 81.13 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.16 B    | 4.7           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 66.99 B    | 4.5           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.38 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '601.42 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 492.88 B   | 82.0          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 108.53 B   | 18.0          | 0.3

Modern Builds (No Rollup)

🛑 The size of the library EmberData has increased by +1.71 KB (+423.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/record-data has increased by +2.0 KB.

Changeset


EmberData +203.66 KB +1.71 KB (+39.03 KB +423.0 B compressed)
    @ember-data/store +98.54 KB -306.0 B (+18.88 KB -74.09 B compressed)
        @ember-data/store/-private/system/core-store +17.24 KB +123.0 B (+3.3 KB +29.78 B compressed)
        @ember-data/store/-private/system/model/internal-model +15.35 KB +21.0 B (+2.94 KB +5.08 B compressed)
        @ember-data/store/-private/index +4.11 KB -51.0 B (+806.54 B -12.35 B compressed)
        @ember-data/store/-private/system/store/record-data-store-wrapper +3.33 KB -36.0 B (+654.2 B -8.72 B compressed)
        @ember-data/store/-private/system/snapshot +3.0 KB +155.0 B (+589.05 B +37.53 B compressed)
        @ember-data/store/-private/system/references/has-many +1.45 KB -66.0 B (+284.94 B -15.98 B compressed)
        @ember-data/store/-private/system/references/belongs-to +1.21 KB -42.0 B (+236.65 B -10.17 B compressed)
        @ember-data/store/-private/system/backburner +253.0 B -15.0 B (+48.48 B -3.63 B compressed)
        @ember-data/store/-private/utils/brand 0.0 B -258.0 B (0.0 B -62.47 B compressed)
        @ember-data/store/-private/system/record-data-for +373.0 B +138.0 B (+71.47 B +33.41 B compressed)
        @ember-data/store/-private/system/ts-upgrade-map 0.0 B -234.0 B (0.0 B -56.66 B compressed)
        @ember-data/store/-private/ts-interfaces/record-data-store-wrapper +95.0 B -41.0 B (+18.2 B -9.93 B compressed)
    @ember-data/record-data +27.65 KB +2.0 KB (+5.3 KB +497.09 B compressed)
        @ember-data/record-data/-private/relationships/state/relationship +7.63 KB -277.0 B (+1.46 KB -67.07 B compressed)
        @ember-data/record-data/-private/record-data +8.01 KB +249.0 B (+1.53 KB +60.29 B compressed)
        @ember-data/record-data/-private/relationships/state/belongs-to +2.92 KB -3.0 B (+573.33 B -0.73 B compressed)
        @ember-data/record-data/-private/relationships/state/has-many +2.68 KB +10.0 B (+525.81 B +2.42 B compressed)
        @ember-data/record-data/-private/ordered-set +1.13 KB -12.0 B (+221.9 B -2.91 B compressed)
        @ember-data/record-data/-private/relationships/state/create +971.0 B -102.0 B (+186.06 B -24.7 B compressed)
        @ember-data/record-data/-private/index +1.33 KB +341.0 B (+260.22 B +82.57 B compressed)
        @ember-data/record-data/-private/accessors +621.0 B +146.0 B (+118.99 B +35.35 B compressed)
        @ember-data/record-data/-private/graph/index +1.66 KB +1.66 KB (+325.95 B +411.86 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '203.66 KB' │
│ compressed │ '39.03 KB'  │
│  packages  │      8      │
│  modules   │     142     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '98.54 KB' │
│  compressed  │ '18.88 KB' │
│ % Of Library │   '48.4'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.24 KB  | 3.30 KB    | 17.5          | 8.5
	@ember-data/store/-private/system/model/internal-model                             | 15.35 KB  | 2.94 KB    | 15.6          | 7.5
	@ember-data/store/-private/system/model/states                                     | 5.47 KB   | 1.05 KB    | 5.5           | 2.7
	@ember-data/store/-private/system/fetch-manager                                    | 4.96 KB   | 973.64 B   | 5.0           | 2.4
	@ember-data/store/-private/system/record-array-manager                             | 4.47 KB   | 876.29 B   | 4.5           | 2.2
	@ember-data/store/-private/system/store/finders                                    | 4.37 KB   | 857.51 B   | 4.4           | 2.1
	@ember-data/store/-private/index                                                   | 4.11 KB   | 806.54 B   | 4.2           | 2.0
	@ember-data/store/-private/identifiers/cache                                       | 3.86 KB   | 757.68 B   | 3.9           | 1.9
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.33 KB   | 654.20 B   | 3.4           | 1.6
	@ember-data/store/-private/system/snapshot                                         | 3.00 KB   | 589.05 B   | 3.0           | 1.5
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.91 KB   | 571.23 B   | 3.0           | 1.4
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.25 KB   | 441.30 B   | 2.3           | 1.1
	@ember-data/store/-private/system/ds-model-store                                   | 1.99 KB   | 390.52 B   | 2.0           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 370.02 B   | 1.9           | 0.9
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 289.16 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/has-many                              | 1.45 KB   | 284.94 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.27 KB   | 249.11 B   | 1.3           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.21 KB   | 236.65 B   | 1.2           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 220.55 B   | 1.1           | 0.6
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 206.57 B   | 1.1           | 0.5
	@ember-data/store/-private/system/internal-model-map                               | 983.00 B  | 188.36 B   | 1.0           | 0.5
	@ember-data/store/-private/system/references/record                                | 979.00 B  | 187.59 B   | 1.0           | 0.5
	@ember-data/store/index                                                            | 936.00 B  | 179.36 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 917.00 B  | 175.71 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 892.00 B  | 170.92 B   | 0.9           | 0.4
	@ember-data/store/-private/system/model/notify-changes                             | 866.00 B  | 165.94 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 764.00 B  | 146.40 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 144.29 B   | 0.7           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 689.00 B  | 132.02 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.59 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 106.54 B   | 0.6           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 96.96 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 505.00 B  | 96.77 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.04 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.32 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.23 B    | 0.4           | 0.2
	@ember-data/store/-private/system/diff-array                                       | 438.00 B  | 83.93 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.64 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.30 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 373.00 B  | 71.47 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.66 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.55 B    | 0.3           | 0.2
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.57 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 253.00 B  | 48.48 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.15 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.62 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 36.98 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 36.40 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.77 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.39 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 18.20 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 95.00 B   | 18.20 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 18.20 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.24 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 17.05 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 89.00 B   | 17.05 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.28 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.28 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.52 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 14.94 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.37 B    | 0.1           | 0.0

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '27.65 KB' │
│  compressed  │ '5.30 KB'  │
│ % Of Library │   '13.6'   │
└──────────────┴────────────┘
	Module                                                                      | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                | 8.01 KB   | 1.53 KB    | 29.0          | 3.9
	@ember-data/record-data/-private/relationships/state/relationship           | 7.63 KB   | 1.46 KB    | 27.6          | 3.7
	@ember-data/record-data/-private/relationships/state/belongs-to             | 2.92 KB   | 573.33 B   | 10.6          | 1.4
	@ember-data/record-data/-private/relationships/state/has-many               | 2.68 KB   | 525.81 B   | 9.7           | 1.3
	@ember-data/record-data/-private/graph/index                                | 1.66 KB   | 325.95 B   | 6.0           | 0.8
	@ember-data/record-data/-private/index                                      | 1.33 KB   | 260.22 B   | 4.8           | 0.7
	@ember-data/record-data/-private/ordered-set                                | 1.13 KB   | 221.90 B   | 4.1           | 0.6
	@ember-data/record-data/-private/relationships/state/create                 | 971.00 B  | 186.06 B   | 3.4           | 0.5
	@ember-data/record-data/-private/accessors                                  | 621.00 B  | 118.99 B   | 2.2           | 0.3
	@ember-data/record-data/-private/coerce-id                                  | 406.00 B  | 77.79 B    | 1.4           | 0.2
	@ember-data/record-data/-private/normalize-link                             | 249.00 B  | 47.71 B    | 0.9           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data     | 100.00 B  | 19.16 B    | 0.4           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.76 KB' │
│  compressed  │ '4.17 KB'  │
│ % Of Library │   '10.7'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.12 KB   | 1.36 KB    | 32.7          | 3.5
	@ember-data/serializer/-private/embedded-records-mixin     | 4.30 KB   | 843.52 B   | 19.8          | 2.1
	@ember-data/serializer/json-api                            | 3.72 KB   | 729.32 B   | 17.1          | 1.8
	@ember-data/serializer/rest                                | 2.71 KB   | 532.33 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 231.86 B   | 5.4           | 0.6
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.21 B   | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 93.89 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.46 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 67.25 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 54.80 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 46.56 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 46.37 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.19 B    | 1.0           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.72 KB' │
│  compressed  │ '3.59 KB'  │
│ % Of Library │   '9.2'    │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 6.20 KB   | 1.19 KB    | 33.1          | 3.0
	@ember-data/model/-private/system/many-array                          | 2.41 KB   | 473.11 B   | 12.9          | 1.2
	@ember-data/model/-private/errors                                     | 2.03 KB   | 398.96 B   | 10.9          | 1.0
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.30 KB   | 255.43 B   | 7.0           | 0.6
	@ember-data/model/-private/index                                      | 1.29 KB   | 253.13 B   | 6.9           | 0.6
	@ember-data/model/-private/system/relationships/ext                   | 1.23 KB   | 241.44 B   | 6.6           | 0.6
	@ember-data/model/-private/attr                                       | 673.00 B  | 128.96 B   | 3.5           | 0.3
	@ember-data/model/-private/belongs-to                                 | 663.00 B  | 127.04 B   | 3.5           | 0.3
	@ember-data/model/-private/system/promise-many-array                  | 642.00 B  | 123.02 B   | 3.3           | 0.3
	@ember-data/model/-private/has-many                                   | 626.00 B  | 119.95 B   | 3.3           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.12 B    | 2.5           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.69 B    | 2.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 412.00 B  | 78.94 B    | 2.1           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 408.00 B  | 78.18 B    | 2.1           | 0.2

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.14 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.37 KB   | 1.60 KB    | 46.1          | 4.1
	@ember-data/adapter/error                                     | 1.91 KB   | 375.39 B   | 10.5          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.82 KB   | 357.76 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.14 KB   | 223.05 B   | 6.3           | 0.6
	@ember-data/adapter/-private/index                            | 1.03 KB   | 202.35 B   | 5.7           | 0.5
	@ember-data/adapter/json-api                                  | 1.02 KB   | 199.86 B   | 5.6           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 151.76 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 549.00 B  | 105.20 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 91.97 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.99 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.49 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 219.00 B  | 41.96 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 76.00 B   | 14.56 B    | 0.4           | 0.0

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.50 KB' │
│  compressed  │ '1.82 KB' │
│ % Of Library │   '4.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 455.87 B   | 24.5          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 378.26 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 233.20 B   | 12.5          | 0.6
	ember-data/setup-container                        | 503.00 B  | 96.38 B    | 5.2           | 0.2
	ember-data/-private/core                          | 321.00 B  | 61.51 B    | 3.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.93 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.50 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.09 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.94 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.56 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.56 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.18 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.41 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.45 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.30 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.54 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.54 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.77 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 31.04 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 565.09 B   | 43.3          | 1.4
	ember-inflector/lib/system/inflections            | 1.59 KB   | 311.77 B   | 23.9          | 0.8
	ember-inflector/index                             | 473.00 B  | 90.63 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.25 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.47 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.93 B    | 4.7           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 59.01 B    | 4.5           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.72 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '529.84 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 434.21 B   | 82.0          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.62 B    | 18.0          | 0.2

@runspired runspired added 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 performance labels Apr 17, 2021
@runspired runspired mentioned this pull request Apr 19, 2021
Merged
@runspired runspired force-pushed the runspired/relationship-graph branch from 38c9547 to 31dbbb7 Compare April 20, 2021 17:41
@runspired runspired changed the base branch from master to feat/abstract-graph-tests April 20, 2021 17:42
@runspired runspired force-pushed the feat/abstract-graph-tests branch from 010804a to b62c4ff Compare April 21, 2021 04:10
@runspired runspired force-pushed the runspired/relationship-graph branch from c7e83c2 to 1acd5b5 Compare April 21, 2021 04:20
@runspired runspired mentioned this pull request Apr 21, 2021
Closed
@runspired runspired force-pushed the runspired/relationship-graph branch from 1acd5b5 to 62d849f Compare April 21, 2021 10:05
@runspired runspired changed the title [WIP] chore: convert relationships to use identifiers chore: convert relationships to use identifiers Apr 21, 2021
@runspired runspired marked this pull request as ready for review April 21, 2021 21:34
snewcomer
snewcomer approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the most knowledgeable person to review this PR but I did learn a few things! Nothing stands out as out of place and you certainly have an idea of where this work is heading. Great job and appreciate you walking me through this PR!!

packages/record-data/addon/-private/graph/index.ts Show resolved Hide resolved
packages/record-data/addon/-private/graph/index.ts Show resolved Hide resolved
packages/record-data/addon/-private/graph/index.ts Outdated Show resolved Hide resolved
packages/record-data/addon/-private/graph/index.ts Show resolved Hide resolved
packages/record-data/addon/-private/relationships/state/belongs-to.ts Outdated Show resolved Hide resolved
@kiwiupover
Copy link

Keep up the great work @runspired

@delete-merged-branch delete-merged-branch bot deleted the branch master April 22, 2021 22:35
@runspired runspired force-pushed the runspired/relationship-graph branch from 6fdd826 to 2bd374f Compare April 22, 2021 22:46
@runspired runspired changed the base branch from feat/abstract-graph-tests to master April 22, 2021 22:48
@runspired runspired merged commit a37309a into master Apr 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the runspired/relationship-graph branch April 23, 2021 00:39
@runspired runspired mentioned this pull request Apr 23, 2021
Closed
@runspired runspired mentioned this pull request May 12, 2021
Closed
@runspired runspired added 🏷️ perf PRs that improve performance in a notable way and removed performance labels May 27, 2021
@ijlee2 ijlee2 mentioned this pull request Aug 31, 2021
Merged
40 tasks
@runspired runspired added this to the Public Graph API milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
🏷️ perf PRs that improve performance in a notable way 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
Relationship Refactor
Status: Completed
Milestone
Public Graph API
Development

Successfully merging this pull request may close these issues.
3 participants
@runspired @kiwiupover @snewcomer