[CHORE] AssetSize check for both modern and IE11 builds #6826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance Report for bb46184 Relationship Analysis |
|
Asset Size Report for bb46184 IE11 Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis (IE11)Modern Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis (Modern)Modern Builds (No Rollup) EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis (Modern) |
runspired
added
🏷️ chore
runspired
changed the title
runspired
force-pushed
the
chore/ie-11-asset-check
branch
from
62a07f0 to
64c8075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11!
Our targets for builds of
ember-dataare set by the dummy app in tests since we are an addon here: https://github.com/emberjs/data/blob/master/packages/-ember-data/tests/dummy/config/targets.jsPreviously we weren't building for IE11 outside of the max transpilation test (I'd assumed we were since often IE11 is the default for production).
This fixes that and takes the opportunity to split out our asset monitoring to monitor BOTH IE11 and No-IE11 sizes (e.g.
latest chrome|safari|firefox).Fortunately our delta here wasn't so big (17kb uncompressed, 1kb compressed) so likely our use of rollup and aggressive optimization have already eliminated a lot of the low-hanging fruit of getting off of IE11.
I would expect IE11 support to turn into a more obviously large portion of our codebase as we move away from ObjectProxy, PromiseProxy, and ArrayProxy when IE11 support is unneeded.
Rollup!
Additionally since we now have the infra to do this easily we produce and diff the modern assets a second time without rolling up our
-privatedirectory. This check will always pass, but it allows us to see where we still have modules in our internals that perhaps don't belong more easily.