Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] improve urlForFindAll example #6792

Merged

Conversation

mcfiredrill
Copy link
Contributor

While the example provided is valid, I think a slightly more fleshed out
example of usage might be more helpful for newcomers.

While the example provided is valid, I think a slightly more fleshed out
example of usage might be more helpful for newcomers.
@ghost
Copy link

ghost commented Nov 26, 2019

@mcfiredrill thanks for contributing!
longer-term we are trying to clean up all of these embedded examples to make ember-data's API documentation coherent and polished. (tl;dr here: https://www.notion.so/QUEST-issue-documentation-draft-94444df09d804ae7bce9665401f462be). We'll be putting together the actual QUEST issue soon.

@mcfiredrill
Copy link
Contributor Author

@efx Thanks for the link! I'd love to help out with that effort if I can.

@ghost
Copy link

ghost commented Nov 26, 2019

@mcfiredrill awesome, that would be greatly appreciated. I will cc you once I create the QUEST 😄

@mcfiredrill mcfiredrill changed the title improve urlForFindAll example [DOC] improve urlForFindAll example Nov 30, 2019
@Gaurav0
Copy link
Contributor

Gaurav0 commented Dec 2, 2019

LGTM

@runspired runspired merged commit 949c089 into emberjs:master Dec 6, 2019
@mcfiredrill mcfiredrill deleted the improve-urlforfindall-example branch December 6, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants