Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX TEST] reloading tests for adapter encapsulation side quest - shouldReloadAll #6673

Merged
merged 10 commits into from
Nov 9, 2019
Merged

[BUGFIX TEST] reloading tests for adapter encapsulation side quest - shouldReloadAll #6673

merged 10 commits into from
Nov 9, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Nov 5, 2019 •
edited by runspired
Loading

For #6666

It additionally contains fixes for when adapters do not implement shouldReloadAll and shouldBackgroundReloadAll

@runspired runspired added 🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🌲 📦 Encapsulation & Interface Tests 📦 🌲 🎯 canary PR is targeting canary (default) labels Nov 5, 2019
@Gaurav0 Gaurav0 force-pushed the adapter_encapsulation_reload_tests branch 2 times, most recently from 8247348 to f233afe Compare November 5, 2019 20:19
@Gaurav0 Gaurav0 changed the title [WIP] [TEST] reloading tests for adapter encapsulation side quest [TEST] reloading tests for adapter encapsulation side quest - shouldReloadAll Nov 5, 2019
@runspired runspired self-requested a review November 6, 2019 02:18
runspired
runspired reviewed Nov 9, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking great! a few things needed, then we can merge these and get to work on the next batch :)

packages/store/addon/-private/system/core-store.ts Outdated Show resolved Hide resolved
packages/unpublished-adapter-encapsulation-test-app/tests/integration/reload-test.js Show resolved Hide resolved
packages/unpublished-adapter-encapsulation-test-app/tests/integration/reload-test.js Outdated Show resolved Hide resolved
packages/unpublished-adapter-encapsulation-test-app/tests/integration/reload-test.js Outdated Show resolved Hide resolved
@Gaurav0 Gaurav0 force-pushed the adapter_encapsulation_reload_tests branch from 8905b39 to 7bebc15 Compare November 9, 2019 17:47
@runspired runspired added the 🏷️ bug This PR primarily fixes a reported issue label Nov 9, 2019
@runspired runspired changed the title [TEST] reloading tests for adapter encapsulation side quest - shouldReloadAll [BUGFIX TEST] reloading tests for adapter encapsulation side quest - shouldReloadAll Nov 9, 2019
@runspired runspired merged commit c20c3da into emberjs:master Nov 9, 2019
@Gaurav0 Gaurav0 deleted the adapter_encapsulation_reload_tests branch November 9, 2019 18:34
@runspired runspired removed the 🎯 canary PR is targeting canary (default) label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gaurav0 @runspired