[DOCS BETA RELEASE] Fix @ember-data/model package is blank #6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaurav0
force-pushed
the
fix_docs_model
branch
from
2234890 to
5311b2e
Compare
Gaurav0
changed the title
runspired
reviewed
Sep 12, 2019
| @@ -138,6 +138,9 @@ import { computedMacroWithOptionalParams } from './util'; | |||
| `ref.reload` to fetch the resources. | |||
|
|
|||
| @method hasMany | |||
| @public | |||
| @static | |||
| @for @ember-data/model | |||
There was a problem hiding this comment.
(going to merge, we can always remove it later, but I suspect we only needed to mark this as public+static)
There was a problem hiding this comment.
I'm not sure why, but it is needed. I saw this pattern in the ember.js repo.
4 tasks
Gaurav0
added a commit
to Gaurav0/data
that referenced
this pull request
Sep 12, 2019
Gaurav0
added a commit
to Gaurav0/data
that referenced
this pull request
Sep 12, 2019
runspired
pushed a commit
that referenced
this pull request
Sep 12, 2019
runspired
pushed a commit
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that Model class and attr, hasMany, and belongsTo functions appear in ember-data/model package in docs.
Before:
After: