[BUGFIX]: set Content-Type for non GET requests only #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Aug 17, 2019
packages/adapter/addon/json-api.js
Outdated
| @@ -143,6 +143,8 @@ import { pluralize } from 'ember-inflector'; | |||
| const JSONAPIAdapter = RESTAdapter.extend({ | |||
| defaultSerializer: '-json-api', | |||
|
|
|||
| defaultContentType: 'application/vnd.api+json', | |||
There was a problem hiding this comment.
perhaps privatize with _?
snewcomer
commented
Aug 17, 2019
| options = fetchOptions(options, this); | ||
| } else { | ||
| if (options.data && options.type !== 'GET') { |
There was a problem hiding this comment.
A GET request with a non-simple content-type will result in a preflight request. One consequence of adding the Content-Type header on GET (where we used to not) is the backend server perhaps doesn't expect this and won't return the right a-c-a-o header.
There was a problem hiding this comment.
Can we leave this explanation of this conditional as a comment in the code?
runspired
approved these changes
Aug 22, 2019
snewcomer
force-pushed
the
sn/fix-content-type-headers
branch
from
4fc3201 to
f336432
Compare
This was referenced Aug 23, 2019
|
@snewcomer Is this fix part of any release? |
|
@brandynbennett it is in beta |
|
Awesome thanks!
… On Oct 8, 2019, at 7:40 PM, Chris Thoburn ***@***.***> wrote:
@brandynbennett it is in beta
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggybacked off of #6169 with some tests and default content type header
close #6341 #6167 #6324