RecordData errors #6197
Merged
RecordData errors #6197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorT
force-pushed
the
igor/record-data-errors
branch
2 times, most recently
from
caa5172 to
4dadc81
Compare
igorT
commented
Jun 26, 2019
mike-north
reviewed
Jun 27, 2019
|
@mike-north reviewed in person |
runspired
requested changes
Jun 28, 2019
There was a problem hiding this comment.
Outside of these review comments I have the additional concern that we seem to have put a lot of new private methods on Model. If this logic truly belongs living with the record can it be encapsulated as util functions within the module instead of leaking methods to consumers?
Added two methods, which after we have a subscription mechanism with custom model classes can be isolated in a callback/not exposed |
runspired
approved these changes
Jun 28, 2019
igorT
force-pushed
the
igor/record-data-errors
branch
3 times, most recently
from
0182979 to
73c1661
Compare
igorT
force-pushed
the
igor/record-data-errors
branch
from
73c1661 to
d011ece
Compare
pete-the-pete
pushed a commit
to pete-the-pete/data
that referenced
this pull request
Jul 4, 2019
pete-the-pete
pushed a commit
to pete-the-pete/data
that referenced
this pull request
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements emberjs/rfcs#465
Also cleans up some of the feature flagging infra thanks to @rwjblue