[BUGFIX] destroyRecord should also unload #5455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetanley
commented
Apr 26, 2018
|
|
||
| env.adapter.deleteRecord = function() { | ||
| return EmberPromise.resolve({ | ||
| data: { |
There was a problem hiding this comment.
it's important to note that no matter what this value is, as long as it is not undefined, the test seems to still fail.
runspired
force-pushed
the
record-not-removed-when-payload-returned-from-adapter-method
branch
from
bb70fbb to
35cc95f
Compare
runspired
changed the title
fivetanley
force-pushed
the
record-not-removed-when-payload-returned-from-adapter-method
branch
from
35cc95f to
8f93c0d
Compare
fivetanley
force-pushed
the
record-not-removed-when-payload-returned-from-adapter-method
branch
2 times, most recently
from
75e5638 to
1b84fb5
Compare
runspired
force-pushed
the
record-not-removed-when-payload-returned-from-adapter-method
branch
2 times, most recently
from
8bde815 to
f40c60d
Compare
runspired
reviewed
Jul 27, 2018
runspired
force-pushed
the
record-not-removed-when-payload-returned-from-adapter-method
branch
2 times, most recently
from
018568d to
6c51fe4
Compare
It seems common for APIs to return a paylaod when deleting a record. Although there is a test for when `undefined` is returned from `deleteRecord` in the adapter here: https://github.com/emberjs/data/blob/master/tests/integration/records/delete-record-test.js#L87 There are currently no tests showing what happens when you return a payload. It seems like the correct behavior for destroyRecord should be `deleteRecord` + `save` + `unloadRecord`.
…Record + save refactor delete-record-test to new style add assertion messages
runspired
force-pushed
the
record-not-removed-when-payload-returned-from-adapter-method
branch
from
30f3ee3 to
f2464c1
Compare
|
Any progress here? |
|
Closing in favor of #7258 |
runspired
deleted the
record-not-removed-when-payload-returned-from-adapter-method
branch
runspired
restored the
record-not-removed-when-payload-returned-from-adapter-method
branch
runspired
deleted the
record-not-removed-when-payload-returned-from-adapter-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems common for APIs to return a paylaod when deleting a record.
Although there is a test for when
undefinedis returned fromdeleteRecordin the adapter here: https://github.com/emberjs/data/blob/master/tests/integration/records/delete-record-test.js#L87There are currently no tests showing what happens when you return a
payload. It seems like the correct behavior for destroyRecord should be
deleteRecord+save+unloadRecord.