[BUGFIX release] unloadRecord + findRecord + orphaned relationships #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
commented
Jul 29, 2017
| if (this.isDestroyed || this.isDestroying) { return; } | ||
|
|
||
| // just in-case we are not one of the orphaned, we should still | ||
| // still destroy outselves |
There was a problem hiding this comment.
typo: outselves -> ourselves
rwjblue
approved these changes
Jul 29, 2017
addon/-private/system/store.js
Outdated
| @@ -1128,14 +1128,13 @@ Store = Service.extend({ | |||
| let internalModel = this._internalModelsFor(modelName).get(trueId); | |||
|
|
|||
| if (!internalModel) { | |||
There was a problem hiding this comment.
Ideally we can refactor this to avoid if (! with an else clause (and instead flipping the blocks around to remove the !). Definitely fine for a follow up PR though.
There was a problem hiding this comment.
nah i can doit as part of this one.
There was a problem hiding this comment.
Awesome, thank you. It is much easier for me to read this way.
stefanpenner
force-pushed
the
unload-with-orphaned-relationships-and-sync-find
branch
from
ce34582 to
b9f79ab
Compare
rwjblue
approved these changes
Jul 29, 2017
Given unloadRecord followed by a synchronous findRecord, we should be sure any orphaned relationships are discarded.
stefanpenner
force-pushed
the
unload-with-orphaned-relationships-and-sync-find
branch
from
b9f79ab to
27c58e5
Compare
Merged
stefanpenner
deleted the
unload-with-orphaned-relationships-and-sync-find
branch
|
released as v2.14.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given unloadRecord followed by a synchronous findRecord, we should be sure
any orphaned relationships are discarded.