Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] keep local state after a deletion #5058

Merged
merged 16 commits into from
Jul 14, 2017
Merged

[BUGFIX] keep local state after a deletion #5058

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
879a814
fix failing tests
runspired Jul 10, 2017
269b1b4
fix async relationships
runspired Jul 10, 2017
b972555
expand comment
runspired Jul 10, 2017
4c3d594
add additional test coverage
runspired Jul 10, 2017
e9acc1f
address feedback from @stefanpenner
runspired Jul 11, 2017
941ca58
fix perf of unloading inverses
runspired Jul 11, 2017
9a72fb5
fix typos
runspired Jul 11, 2017
cee07bd
revert accidental code commenting left behind
runspired Jul 11, 2017
94503e6
code cleanup to address @dhamilton review
runspired Jul 11, 2017
4d7f4e8
address remaining feedback from @hjdivad
runspired Jul 11, 2017
5830358
fix type
runspired Jul 11, 2017
e5cdfe4
fixup function naming
stefanpenner Jul 13, 2017
b538bbf
un-diverge isNew and deletion scenarios
runspired Jul 14, 2017
348b72f
improve code comment
runspired Jul 14, 2017
02a5a46
remove unused code
stefanpenner Jul 14, 2017
8c3f77d
final cleanup
runspired Jul 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/-private/system/model/internal-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,14 +885,14 @@ export default class InternalModel {
let rel = this._relationships.get(name);

rel.clear();
// rel.removeInverseRelationships();
rel.removeInverseRelationships();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjdivad commenting these out didn't make any tests fail o.O

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah it looks like the unload tests assert against the id map and the relationship payloads, but not against relationships (either our side or inverse).

}
});
Object.keys(this._implicitRelationships).forEach((key) => {
let rel = this._implicitRelationships[key];

rel.clear();
// rel.removeInverseRelationships();
rel.removeInverseRelationships();
});
}

Expand Down