Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use let or const #4928

Merged
merged 1 commit into from
Apr 15, 2017
Merged

Don't use let or const #4928

merged 1 commit into from
Apr 15, 2017

Conversation

kratiahuja
Copy link
Contributor

@kratiahuja kratiahuja commented Apr 15, 2017

It is breaking ember-cli-fastboot tests. Fixes: #4927

cc: @runspired @stefanpenner @hjdivad

It is breaking `ember-cli-fastboot` tests.
@runspired
Copy link
Contributor

Thanks @kratiahuja. I forget we can't have nice things ;)

@kratiahuja
Copy link
Contributor Author

kratiahuja commented Apr 15, 2017

On that note, why is ember-data only being tested against Node 6 (I thought ember-cli supports Node 4)? Travis config shows only Node 6

@runspired
Copy link
Contributor

@bmac seems to have introduced the node 6 change.

@bmac
Copy link
Member

bmac commented Apr 15, 2017

I changed travis to use node 6 because master was broken during the contributor workshop and I wanted to unblock contributors. Sounds like I need to revert back to node 4 and debug the real issue.

@bmac bmac merged commit 8157492 into emberjs:master Apr 15, 2017
@rwjblue
Copy link
Member

rwjblue commented Apr 15, 2017

let and const are fine in node 4, you just have to ensure 'use strict'; is at the top of the file.

@rwjblue
Copy link
Member

rwjblue commented Apr 15, 2017

@bmac - the original reason there was a failure around the time of EmberConf was that a new version of ember-try introduced some issues with npm@2 (which is used by node 4). That was fixed within a couple days of EmberConf, so it should be good now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants