Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores the already private store.reloadRecord method #4705

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Underscores the already private store.reloadRecord method #4705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/-private/system/model/states.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ const DirtyState = {
},

reloadRecord(internalModel, resolve) {
resolve(internalModel.store.reloadRecord(internalModel));
resolve(internalModel.store._reloadRecord(internalModel));
},

rolledBack(internalModel) {
Expand Down Expand Up @@ -565,7 +565,7 @@ const RootState = {
},

reloadRecord(internalModel, resolve) {
resolve(internalModel.store.reloadRecord(internalModel));
resolve(internalModel.store._reloadRecord(internalModel));
},

deleteRecord(internalModel) {
Expand Down
3 changes: 1 addition & 2 deletions addon/-private/system/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,8 +1021,7 @@ Store = Service.extend({
@param {DS.Model} internalModel
@return {Promise} promise
*/
// TODO @runspired this should be underscored
reloadRecord(internalModel) {
_reloadRecord(internalModel) {
let modelName = internalModel.type.modelName;
let adapter = this.adapterFor(modelName);
let id = internalModel.id;
Expand Down