Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation for resetAttribute #4678

Merged
merged 3 commits into from Nov 30, 2016
Merged

update documentation for resetAttribute #4678

merged 3 commits into from Nov 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 22, 2016

It was not clear from reading the API documentation that this feature is hidden behind a feature flag. I think it will be helpful to include the following note to provide guidance to users.

@pangratz
Copy link
Member

Can you update the documentation and name the feature ds-rollback-attribute, which will be the case once #4685 is merged.

Thanks!

@pangratz pangratz merged commit da58ec5 into emberjs:master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants