Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add section on commit tagging to CONTRIBUTING.md #4244

Merged
merged 1 commit into from
Mar 27, 2016

Conversation

courajs
Copy link
Contributor

@courajs courajs commented Mar 18, 2016

2 questions:

  • Does ember data use feature flags in the same way as ember.js?
  • I left "submit your PR against emberjs:master", since people's remote in their data repo may be named emberjs. I could also change it to data:master

@courajs
Copy link
Contributor Author

courajs commented Mar 18, 2016

For #4238


### Other

In general almost all commits should fall into one of these categories. In the cases where they don't please submit your PR untagged. An Ember contributor will let you know if tagging is required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use An ember-data contributor will let ... here

@pangratz
Copy link
Member

Does ember data use feature flags in the same way as ember.js?

Basically yes, the only difference is that isEnabled is imported from ember-data/-private/features;

I left "submit your PR against emberjs:master", since people's remote in their data repo may be named emberjs. I could also change it to data:master

What do you think of changing this to "submit your PR against the master branch of https://github.com/emberjs/data"? I think this should be clear enough where to create PR to...


Thank you so much @courajs for helping out here. Much appreciated!!!

@bmac @fivetanley since you are the masters of release ceremony, can you take a look here?

@courajs
Copy link
Contributor Author

courajs commented Mar 18, 2016

I opted to just say "against the master branch.", unless you think the url is useful.
They are reading this on the proper repo, after all

@bmac
Copy link
Member

bmac commented Mar 27, 2016

Looks great. Thanks @courajs

@bmac bmac merged commit 7ca33da into emberjs:master Mar 27, 2016
@pangratz pangratz mentioned this pull request Mar 27, 2016
5 tasks
@courajs courajs deleted the patch-2 branch September 10, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants