Avoid errors when ember-cli-shims is not included. #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restarted travis. Looked like the original issue was unrelated to this code change. |
|
Ya, but soon we will not be using ember-cli-shims at all (once ember addon follows ember-data's lead and ships its own public modules) so it makes sense to ensure that we don't error when it isn't present... |
|
Agreed. I see now my comment was ambiguous. I intended to suggest the reason that travis failed appeared unrelated to this code change. |
bmac
added a commit
that referenced
this pull request
Mar 5, 2016
Avoid errors when ember-cli-shims is not included.
|
Ahh! I see, sorry about the confusion/noise :) |
Turbo87
added a commit
to Turbo87/active-model-adapter
that referenced
this pull request
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4192.