[BUGFIX beta] prevent calls to store.query leaking #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the result from `store.query` is intended to never be re-used as we delegate to the server for the truth of a query, the user still needs an escape hatch to destroy these AdapterPopulatedRecordArrays created by query in order to prevent excessive memory. Before, calling `destroy` on an AdapterPopulatedRecordArray (the type returned from store.query), the logic in RecordArrayManager#unregisterRecordArray did not account for adapter populated record arrays resulting in a leak. This commit changes the logic to search for the array in the RecordArrayManager's AdapterPopulatedRecordArray collection when unregistering a record array. Fixes emberjs#4041
fivetanley
added a commit
that referenced
this pull request
Jan 5, 2016
…ay-leaks [BUGFIX beta] prevent calls to store.query leaking
|
In the changelog I only see this fix for 2.3.0, was it merged to 1.13.x anywhere? |
|
I do not believe this pr was merged into 1.13 @GeekSMN. |
|
Would getting this in 1.13 be possible or are there blocking differences? We're seeing a gradual leak that could be this, but can't migrate to 2.0 just yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the result from
store.queryis intended to never be re-usedas we delegate to the server for the truth of a query, the user still
needs an escape hatch to destroy these AdapterPopulatedRecordArrays
created by query in order to prevent excessive memory.
Before, calling
destroyon an AdapterPopulatedRecordArray (the typereturned from store.query), the logic in
RecordArrayManager#unregisterRecordArray did not account for adapter
populated record arrays resulting in a leak.
This commit changes the logic to search for the array in the
RecordArrayManager's AdapterPopulatedRecordArray collection when
unregistering a record array.
Fixes #4041