-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX beta] Implement public module API. #3995
Conversation
This replaces the public module API from ember-cli-shims.
LGTM 👍 |
Updated again, added the following:
In order to keep backwards compat, we must honor the version of ember-data that is present in If |
In order to keep backwards compat, we must honor the version of ember-data that is present in `bower.json` (even though it is not needed). This is due to the fact that many people update the `package.json` and `bower.json` versions of Ember Data completely independently. If `bower.json` includes `ember-data` a warning will be issued, and that version will be used.
`config/environment.js` is used by ember-cli to allow the addon to provide default configuration to the consuming app. In this case, the configuration here is for the addon's internal development so it belongs in `tests/dummy/config/environment.js` instead.
When using ember-cli-shims prior to 0.1.0, the `ember-data` module that we provide in this addon is overridden by the one provided by the shims repo. This warning should help folks understand what to do *before* they notice an issue.
Added two more changes:
|
[BUGFIX beta] Implement public module API.
Thanks @rwjblue. |
define && define.petal
(which is set by loader.js) is present.bower.json
includesember-data
a warning will be issued, and thatversion will be used.