[BUGFIX beta] Correctly handle object level errors in json api #3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmac any chance of a review? |
|
Looks good to me. @tchak do you have time to take a look at this pr? |
| let title = 'Invalid Attribute'; | ||
| let pointer = `/data/attributes/${key}`; | ||
| if (key === PRIMARY_ATTRIBUTE_KEY) { | ||
| title = 'Invalid Object'; |
There was a problem hiding this comment.
"Invalid Document" seems more inline with JSON-API naming.
|
@adam-knights Thank's a lot for you PR. It is very welcome and needed! |
|
Thanks @tchak I changed the title to Invalid Document as per your comment. _base would suggest its private when this feels like something people should be happy accessing. Configurable sounds good. I could do that in this PR (or a second one after this is merged, leaving base as default) if you could point me toward something else in a file in the codebase that is configurable so I could follow a similar pattern that would get me going. |
|
@bmac I am 👍 on this |
bmac
added a commit
that referenced
this pull request
Nov 11, 2015
[BUGFIX beta] Correctly handle object level errors in json api
|
Thanks @adam-knights |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3602. As per the JSON API spec object level errors should be placed in an object with pointer
/data.I have chosen to put object level data into errors.base, but this could be anything. If anyone is already using base in the form
pointer: '/data/attributes/basethen the object level ones are combined with this.This is my first ever open source pull request so I fully expect to have missed other things I need to do or improve the code's style.