[BUGFIX beta] Fix JSONSerializer.serializeHasMany() issue #3760 #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebweaver
added a commit
to sebweaver/ember-localforage-adapter
that referenced
this pull request
Sep 14, 2015
Temp workaround for ED issue emberjs/data#3760 until the PR emberjs/data#3765 will be merged. Also change class structure to fit the current one (with a dedicated `_shouldSerializeHasMany` method).
sebweaver
added a commit
to sebweaver/ember-localforage-adapter
that referenced
this pull request
Sep 14, 2015
Temp workaround for ED issue emberjs/data#3760 until PR emberjs/data#3765 is merged. Change class structure also to reflect the new one introduced earlier by ED 1.13 (with dedicated `_shouldSerializeHasMany`).
|
|
||
| env.store.serializerFor("post").serializeHasMany(post._createSnapshot(), json, { key: "comments", options: {} }); | ||
|
|
||
| console.log(json); |
There was a problem hiding this comment.
Could you remove this console.log?
`serializeHasMany()` omits unknown relationships of pushed record rather than setting them to `undefined`.
|
My bad, I removed the extraneous console.log. |
bmac
added a commit
that referenced
this pull request
Sep 17, 2015
[BUGFIX beta] Fix JSONSerializer.serializeHasMany() issue #3760
|
Thanks @sebweaver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serializeHasMany()omits unknown relationships of pushed record rather thansetting them to
undefined.