Add deprecation to relationships without { async: false } #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
force-pushed
the
async-by-default
branch
2 times, most recently
from
2b6253b to
f5e015a
Compare
HeroicEric
force-pushed
the
async-by-default
branch
from
f5e015a to
3713fc4
Compare
| @@ -92,6 +92,10 @@ function belongsTo(modelName, options) { | |||
|
|
|||
| opts = opts || {}; | |||
|
|
|||
| if (typeof opts.async === 'undefined') { | |||
| Ember.deprecate('In the future, relationships will be asynchronous by default. You must set { async: false } if you wish for a relationship remain synchronous.'); | |||
There was a problem hiding this comment.
Can you add which relationship to the deprecation notice please. This way it will be much more annoying to track down.
There was a problem hiding this comment.
Something like model type, relationship key, etc.
|
Can you also add async:false to all our internal tests? |
|
just working on updating the tests now. Should be able to get it done today |
|
closed by #3366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3220
Adds a deprecation to relationships defined without
{ async: false }that warns to add{ async: false }if you wish for the relationship to remain synchronous.