Warnings for incorrect options in belongsTo, resolves #3187 #3226
Conversation
| @@ -93,6 +93,14 @@ function belongsTo(modelName, options) { | |||
|
|
|||
| opts = opts || {}; | |||
|
|
|||
| if (opts.hasOwnProperty('serialize')) { | |||
| Ember.warn('You provided a serialize option, this belongs in the serializer. See DS.Serializer and it\'s implementations http://emberjs.com/api/data/classes/DS.Serializer.html'); | |||
There was a problem hiding this comment.
Can you tell the user for which model they provided it, that would make the warning much less confusing. Something like: In the modelName class, passed a serialize option to the belongsTo relationship key. You most likely want to be configuring that in the serializer...
There was a problem hiding this comment.
Good idea, I'll change the error message.
There was a problem hiding this comment.
Sorry @igorT, I can't figure out how to provide the information you mentioned. I can only get ahold of the modelName which is the name of the model that the relationship is to. I can't find the name of the model or the property on where the belongsTo was used.
There was a problem hiding this comment.
If you move the warning into the getter, you should be able to do this. Perf isn't as important as anything inside Ember.warn/assert etc. gets stripped in production
Warnings for incorrect options in belongsTo, resolves #3187
Display a warning when the user specifies
serializeorembeddedin the options forbelongsTo. These settings belong in the serializer now, I have linked to the relevant documentation pages in order to help the user to do what they meant to do. Resolves #3187.