[REBASE] Model relationships getter #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whatthewhat Could you try passing this test #3084 (comment) on your branch ? |
|
@sly7-7 I get |
whatthewhat
force-pushed
the
model-relationships-getter
branch
from
f97cddc to
69892b4
Compare
|
@whatthewhat Thanks for testing it, so definitely we need something more to make it work |
igorT
added a commit
that referenced
this pull request
Jun 3, 2015
[REBASE] Model relationships getter
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #2741 by @andrewfan.
I've also added a separate commit, that uses the getter in the code that was added after the original PR.
Currently 2 of the new tests are failingfixed, thanks to @igorT!