Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for urlFor methods #3007

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Add tests for urlFor methods #3007

merged 1 commit into from
Apr 17, 2015

Conversation

jamiebuilds
Copy link
Contributor

Resolves #2966

@jamiebuilds
Copy link
Contributor Author

derp, I meant this resolves #2986

@igorT
Copy link
Member

igorT commented Apr 17, 2015

restarted travis

@stefanpenner
Copy link
Member

for the first time in history, appveyor passed but travis failed ;P

@igorT
Copy link
Member

igorT commented Apr 17, 2015

I was just about to screenshot that :)

On Fri, Apr 17, 2015 at 9:27 PM, Stefan Penner [email protected]
wrote:

for the first time in history, appveyor passed but travis failed ;P

—
Reply to this email directly or view it on GitHub
#3007 (comment).

igorT added a commit that referenced this pull request Apr 17, 2015
@igorT
Merge pull request #3007 from thejameskyle/url-for-methods
219b331 
Add tests for urlFor methods
@igorT igorT merged commit 219b331 into emberjs:master Apr 17, 2015
@igorT
Copy link
Member

igorT commented Apr 17, 2015

Thanks!

@jamiebuilds jamiebuilds deleted the url-for-methods branch April 18, 2015 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamiebuilds @igorT @stefanpenner