-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear meta data when unloading all records for a type. Fixes #2772 #2956
Conversation
@@ -1073,6 +1073,7 @@ Store = Service.extend({ | |||
} | |||
|
|||
typeMap.findAllCache = null; | |||
this.typeMapFor(type).metadata = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to do Ember.create(null)
instead of {}
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Are there docs somewhere on Ember.create ? It's not in the website api docs. I'm assuming this is the underlying instantiation method (similar to Ember.set or Ember.get) that get's added to Ember.Object?
@wecc I personally think that makes sense. I'm assuming if desired doing so would involve doing this after unloading the records?
|
@wecc also, any idea why the build can't complete? Can't get the tests to run locally, just hangs forever, seems same issue is happening with the CI tests. |
@runspired failing build should be fixed on master, can you rebase? |
Thanks for the PR! Can you squash/rebase and I'll or @wecc will merge |
Clear meta data when unloading all records for a type. Fixes #2772
No description provided.