Refactored InvalidError handling into a serializer concern. #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
igorT
added a commit
that referenced
this pull request
Oct 16, 2014
Refactored InvalidError handling into a serializer concern.
|
👍 |
|
😍 😍 😍 |
| normalizeErrors: function(type, hash) { | ||
| this.normalizeId(hash); | ||
| this.normalizeAttributes(type, hash); | ||
| this.normalizeRelationships(type, hash); |
There was a problem hiding this comment.
Hey @ahacking,
We're updating our app to latest Ember-Data and we've been having issues in our error processing because of this. When using polymorphic relationships, normalizeRelationships will inspect the hash for a type property. Since this is an error payload, the type property won't be set.
Here's a workaround implementation which works great for us. Do you see any issue with it? I'm thinking of opening a PR with it.
There was a problem hiding this comment.
Can you open an issue for this please as well, just so we can track it
jbourassa
pushed a commit
to didacte/data
that referenced
this pull request
Apr 21, 2015
|
🎆 Thanks! |
jbourassa
pushed a commit
to didacte/data
that referenced
this pull request
May 11, 2015
jbourassa
pushed a commit
to didacte/data
that referenced
this pull request
May 11, 2015
jbourassa
pushed a commit
to didacte/data
that referenced
this pull request
May 11, 2015
jbourassa
pushed a commit
to didacte/data
that referenced
this pull request
May 29, 2015
jbourassa
pushed a commit
to didacte/data
that referenced
this pull request
May 29, 2015
jbourassa
pushed a commit
to didacte/data
that referenced
this pull request
Jun 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
InvalidErrorhandling into a serializer concern.Addresses #1977 by ensuring error keys undergo the same mapping treatment that model attribute and relationship keys do.
Supports #1984 and #1877 by moving the model error serialization concern into the serializer. This PR should remove any objections for not applying all errors which have been sanctioned by the serializer to the record/model errors.
Paves the way for embedded record error handling, with the intent that errors can be mapped/normalized for the specific embedded records to which they apply.