-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document caching behavior of store methods. #4733
Comments
Can I help with doing this? Maybe I could start with |
@ryanlabouve please do! 🙏 |
@rwjblue They are cached, they just never return from cache. Yes, we should document this :) |
@runspired if they never return from cache then what's the reason for caching? |
@GCheung55 because you might want to |
@GCheung55 so that |
Starting with query, I'm wanting to double check my understand of what's happening. If this is right, I'll work on wording and PR:
Should I add something about why these are cached? (as @runspired / @locks ) points out above)? |
The documentation on findAll and findRecord seem to answer some of the questions in the original issue. There are sections about reloading, but they do not link to other docs. |
Boxes checked off, closing this! |
It is my understanding that
this.store.query
andthis.store.queryRecord
will never be cached (they will always do a request), but the documentation does not state that (at least during my quick perusal).We should update the documentation for all of the primary methods to indicate what will happen for repeated calls (do they return prior results, do they always trigger an XHR, etc):
store.query
in Document cache/request behavior ofquery
#4733 #4763store.queryRecord
in [DOC] Documents the caching behavior of queryRecord #4892store.findAll
noopstore.findRecord
noopstore.peekAll
noopstore.peekRecord
in [doc] updating peekRecord documentation with reference to its counterpart f… #4900This API documentation should probably also link to the corresponding
shouldBackgroundReload
type docs that explain how to tweak/modify the behavior.The text was updated successfully, but these errors were encountered: