Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

likely broken code due to refactoring #3629

Closed
stefanpenner opened this issue Aug 5, 2015 · 0 comments
Closed

likely broken code due to refactoring #3629

stefanpenner opened this issue Aug 5, 2015 · 0 comments
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@stefanpenner
Copy link
Member

this if will always be true, i suspect some meaning existed in the past but now something seems sideways.

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/adapters/rest-adapter.js#L818
bmac added a commit to bmac/data that referenced this issue Oct 13, 2015
@bmac
Remove conditional statement that is always true
c46adb1 
Closes emberjs#3629
@bmac bmac mentioned this issue Oct 13, 2015
Merged
bmac added a commit to bmac/data that referenced this issue Oct 16, 2015
@bmac
Remove conditional statement that is always true
2913065 
Closes emberjs#3629
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanpenner @runspired