Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adapter populated record arrays to update themselves #3082

Closed
vinilios opened this issue May 19, 2015 · 1 comment
Closed

Allow adapter populated record arrays to update themselves #3082

vinilios opened this issue May 19, 2015 · 1 comment

Comments

@vinilios
Copy link
Contributor

Calling update method on an adapter populated record array has no effects to the contents of the array as a result of the way update method is implemented. The change to resolve this seems to be trivial and with minor side effects, excluding of course existing misuse of the method.
vinilios added a commit to vinilios/data that referenced this issue May 19, 2015
@vinilios
Functional update for adapter populated record arrays
8d7ca7d 
permit for adapter populated record array contents to be updated by
calling `update` method.

Refs emberjs#3082
@vinilios vinilios mentioned this issue May 21, 2015
Closed
fivetanley pushed a commit to fivetanley/data that referenced this issue Jan 6, 2016
@vinilios
Functional update for adapter populated record arrays
72818f6 
permit for adapter populated record array contents to be updated by
calling `update` method.

refs emberjs#3082
fivetanley pushed a commit to fivetanley/data that referenced this issue Jan 6, 2016
@vinilios
[BUGFIX beta] Functional update for adapter populated record arrays
a24a806 
permit for adapter populated record array contents to be updated by
calling `update` method.

refs emberjs#3082
@fivetanley fivetanley mentioned this issue Jan 6, 2016
Merged
@bmac
Copy link
Member

bmac commented Jan 11, 2016

I believe this is fixed by #4050.

@bmac bmac closed this as completed Jan 11, 2016
bmac pushed a commit that referenced this issue Jan 11, 2016
@vinilios @bmac
[BUGFIX beta] Functional update for adapter populated record arrays
dad2970 
permit for adapter populated record array contents to be updated by
calling `update` method.

refs #3082

(cherry picked from commit a24a806)

Conflicts:
	addon/-private/system/store.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vinilios @bmac and others