-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There's no need to load serializers if and until the adapter fetch promise resolves.
- Loading branch information
Showing
2 changed files
with
294 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,285 @@ | ||
| import setupStore from 'dummy/tests/helpers/store'; | ||
| import Ember from 'ember'; | ||
|
|
||
| import {module, test} from 'qunit'; | ||
|
|
||
| const { run } = Ember; | ||
| const { defer } = Ember.RSVP; | ||
|
|
||
| import DS from 'ember-data'; | ||
|
|
||
| module('unit/store/finders', { | ||
| beforeEach() { | ||
| this.Person = DS.Model.extend({ | ||
| updatedAt: DS.attr('string'), | ||
| name: DS.attr('string'), | ||
| firstName: DS.attr('string'), | ||
| lastName: DS.attr('string') | ||
| }); | ||
|
|
||
| this.Dog = DS.Model.extend({ | ||
| name: DS.attr('string') | ||
| }); | ||
|
|
||
| this.env = setupStore({ person: this.Person, dog: this.Dog }); | ||
| this.store = this.env.store; | ||
| this.adapter = this.env.adapter; | ||
| }, | ||
|
|
||
| afterEach() { | ||
| run(this.env.container, 'destroy'); | ||
| } | ||
| }); | ||
|
|
||
| test('findRecord does not load a serializer until the adapter promise resolves', function(assert) { | ||
| assert.expect(2); | ||
|
|
||
| let deferedFind = defer(); | ||
|
|
||
| this.env.registry.register('adapter:person', DS.Adapter.extend({ | ||
| findRecord: () => deferedFind.promise | ||
| })); | ||
|
|
||
| let serializerLoaded = false; | ||
| let serializerFor = this.store.serializerFor; | ||
| this.store.serializerFor = (modelName) => { | ||
| if (modelName === 'person') { | ||
| serializerLoaded = true; | ||
| } | ||
| return serializerFor.call(this.store, modelName); | ||
| }; | ||
|
|
||
| let storePromise = run(() => this.store.findRecord('person', 1)); | ||
| assert.equal(false, serializerLoaded, 'serializer is not eagerly loaded'); | ||
|
|
||
| return run(() => { | ||
| deferedFind.resolve({ id: 1, name: 'John Churchill' }); | ||
| return storePromise.then(() => { | ||
| assert.equal(true, serializerLoaded, 'serializer is loaded'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| test('findMany does not load a serializer until the adapter promise resolves', function(assert) { | ||
| assert.expect(2); | ||
|
|
||
| let deferedFind = defer(); | ||
|
|
||
| this.env.registry.register('adapter:person', DS.Adapter.extend({ | ||
| findMany: () => deferedFind.promise | ||
| })); | ||
|
|
||
| let serializerLoaded = false; | ||
| let serializerFor = this.store.serializerFor; | ||
| this.store.serializerFor = (modelName) => { | ||
| if (modelName === 'person') { | ||
| serializerLoaded = true; | ||
| } | ||
| return serializerFor.call(this.store, modelName); | ||
| }; | ||
|
|
||
| let storePromise = run(() => { | ||
| this.store.findRecord('person', 1) | ||
| return this.store.findRecord('person', 2); | ||
| }); | ||
| assert.equal(false, serializerLoaded, 'serializer is not eagerly loaded'); | ||
|
|
||
| return run(() => { | ||
| deferedFind.resolve([{ id: 1, name: 'John Churchill' }, { id: 2, name: 'Louis Joseph' }]); | ||
| return storePromise.then(() => { | ||
| assert.equal(true, serializerLoaded, 'serializer is loaded'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| test('findHasMany does not load a serializer until the adapter promise resolves', function(assert) { | ||
| assert.expect(2); | ||
|
|
||
| let deferedFind = defer(); | ||
|
|
||
| this.env.registry.register('adapter:person', DS.Adapter.extend({ | ||
| findHasMany: () => deferedFind.promise | ||
| })); | ||
|
|
||
| this.Person.reopen({ | ||
| dogs: DS.hasMany('dog', { async: true }) | ||
| }); | ||
|
|
||
| let serializerLoaded = false; | ||
| let serializerFor = this.store.serializerFor; | ||
| this.store.serializerFor = (modelName) => { | ||
| if (modelName === 'dog') { | ||
| serializerLoaded = true; | ||
| } | ||
| return serializerFor.call(this.store, modelName); | ||
| }; | ||
|
|
||
| let storePromise = run(() => { | ||
| this.env.store.push({ | ||
| data: { | ||
| type: 'person', | ||
| id: '1', | ||
| attributes: { | ||
| name: 'John Churchill' | ||
| }, | ||
| relationships: { | ||
| dogs: { | ||
| links: { | ||
| related: 'http://exmaple.com/person/1/dogs' | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| return this.store.peekRecord('person', 1).get('dogs'); | ||
| }); | ||
| assert.equal(false, serializerLoaded, 'serializer is not eagerly loaded'); | ||
|
|
||
| return run(() => { | ||
| deferedFind.resolve([{ id: 1, name: 'Scooby' }, { id: 2, name: 'Scrappy' }]); | ||
| return storePromise.then(() => { | ||
| assert.equal(true, serializerLoaded, 'serializer is loaded'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| test('findBelongsTo does not load a serializer until the adapter promise resolves', function(assert) { | ||
| assert.expect(2); | ||
|
|
||
| let deferedFind = defer(); | ||
|
|
||
| this.env.registry.register('adapter:person', DS.Adapter.extend({ | ||
| findBelongsTo: () => deferedFind.promise | ||
| })); | ||
|
|
||
| this.Person.reopen({ | ||
| favoriteDog: DS.belongsTo('dog', { async: true }) | ||
| }); | ||
|
|
||
| let serializerLoaded = false; | ||
| let serializerFor = this.store.serializerFor; | ||
| this.store.serializerFor = (modelName) => { | ||
| if (modelName === 'dog') { | ||
| serializerLoaded = true; | ||
| } | ||
| return serializerFor.call(this.store, modelName); | ||
| }; | ||
|
|
||
| let storePromise = run(() => { | ||
| this.env.store.push({ | ||
| data: { | ||
| type: 'person', | ||
| id: '1', | ||
| attributes: { | ||
| name: 'John Churchill' | ||
| }, | ||
| relationships: { | ||
| favoriteDog: { | ||
| links: { | ||
| related: 'http://exmaple.com/person/1/favorite-dog' | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| return this.store.peekRecord('person', 1).get('favoriteDog'); | ||
| }); | ||
| assert.equal(false, serializerLoaded, 'serializer is not eagerly loaded'); | ||
|
|
||
| return run(() => { | ||
| deferedFind.resolve({ id: 1, name: 'Scooby' }); | ||
| return storePromise.then(() => { | ||
| assert.equal(true, serializerLoaded, 'serializer is loaded'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| test('findAll does not load a serializer until the adapter promise resolves', function(assert) { | ||
| assert.expect(2); | ||
|
|
||
| let deferedFind = defer(); | ||
|
|
||
| this.env.registry.register('adapter:person', DS.Adapter.extend({ | ||
| findAll: () => deferedFind.promise | ||
| })); | ||
|
|
||
| let serializerLoaded = false; | ||
| let serializerFor = this.store.serializerFor; | ||
| this.store.serializerFor = (modelName) => { | ||
| if (modelName === 'person') { | ||
| serializerLoaded = true; | ||
| } | ||
| return serializerFor.call(this.store, modelName); | ||
| }; | ||
|
|
||
| let storePromise = run(() => this.store.findAll('person')); | ||
| assert.equal(false, serializerLoaded, 'serializer is not eagerly loaded'); | ||
|
|
||
| return run(() => { | ||
| deferedFind.resolve([{ id: 1, name: 'John Churchill' }]); | ||
| return storePromise.then(() => { | ||
| assert.equal(true, serializerLoaded, 'serializer is loaded'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| test('query does not load a serializer until the adapter promise resolves', function(assert) { | ||
| assert.expect(2); | ||
|
|
||
| let deferedFind = defer(); | ||
|
|
||
| this.env.registry.register('adapter:person', DS.Adapter.extend({ | ||
| query: () => deferedFind.promise | ||
| })); | ||
|
|
||
| let serializerLoaded = false; | ||
| let serializerFor = this.store.serializerFor; | ||
| this.store.serializerFor = (modelName) => { | ||
| if (modelName === 'person') { | ||
| serializerLoaded = true; | ||
| } | ||
| return serializerFor.call(this.store, modelName); | ||
| }; | ||
|
|
||
| let storePromise = run(() => this.store.query('person', { first_duke_of_marlborough: true })); | ||
| assert.equal(false, serializerLoaded, 'serializer is not eagerly loaded'); | ||
|
|
||
| return run(() => { | ||
| deferedFind.resolve([{ id: 1, name: 'John Churchill' }]); | ||
| return storePromise.then(() => { | ||
| assert.equal(true, serializerLoaded, 'serializer is loaded'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| test('queryRecord does not load a serializer until the adapter promise resolves', function(assert) { | ||
| assert.expect(2); | ||
|
|
||
| let deferedFind = defer(); | ||
|
|
||
| this.env.registry.register('adapter:person', DS.Adapter.extend({ | ||
| queryRecord: () => deferedFind.promise | ||
| })); | ||
|
|
||
| let serializerLoaded = false; | ||
| let serializerFor = this.store.serializerFor; | ||
| this.store.serializerFor = (modelName) => { | ||
| if (modelName === 'person') { | ||
| serializerLoaded = true; | ||
| } | ||
| return serializerFor.call(this.store, modelName); | ||
| }; | ||
|
|
||
| let storePromise = run(() => this.store.queryRecord('person', { first_duke_of_marlborough: true })); | ||
| assert.equal(false, serializerLoaded, 'serializer is not eagerly loaded'); | ||
|
|
||
| return run(() => { | ||
| deferedFind.resolve({ id: 1, name: 'John Churchill' }); | ||
| return storePromise.then(() => { | ||
| assert.equal(true, serializerLoaded, 'serializer is loaded'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|