feedback better unload; use graph colouring rather than allocating array

emberjs · Oct 21, 2016 · 347c3d7 · 347c3d7
1 parent cd119ed
commit 347c3d7
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/addon/-private/system/model/internal-model.js b/addon/-private/system/model/internal-model.js
@@ -136,8 +136,13 @@ export default function InternalModel(type, id, store, _, data) {
     when we are deleted
   */
   this._implicitRelationships = new EmptyObject();
+
+  // Used for coloring during BFS
+  this._bfsId = 0;
 }
 
+let nextBfsId = 1;
+
 InternalModel.prototype = {
   isEmpty: retrieveFromCurrentState('isEmpty'),
   isLoading: retrieveFromCurrentState('isLoading'),
@@ -254,17 +259,17 @@ InternalModel.prototype = {
   allRelatedInternalModels() {
     let array = [];
     let queue = [];
-    let seen = [];
+    let bfsId = nextBfsId++;
     queue.push(this);
-    seen.push(this);
+    this._bfsId = bfsId;
     while (queue.length > 0) {
       let node = queue.shift();
       array.push(node);
       let related = node.directlyRelatedInternalModels();
       related.forEach(internalModel => {
-        if (seen.indexOf(internalModel) === -1) {
+        if (internalModel._bfsId < bfsId) {
           queue.push(internalModel);
-          seen.push(internalModel);
+          internalModel._bfsId = bfsId;
         }
       });
     }